From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64AE2274FDB for ; Wed, 1 Oct 2025 08:11:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759306270; cv=none; b=oJa1E199BXNOK6fCy5j5G36OyXQjmBHsnn9DJi8E9qWq/nR3l04c7gd+zs4SX18JWoErNRSohJqmKJEboqG/GMn7NOX5tVuwmzEFVeTp2mXjZEf293Yq24diyh/C5jSpSQcSPSGzLKwNMF34a6De3D9qOpsqf3vAVI5NYJLbVlg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759306270; c=relaxed/simple; bh=k+98mlzkrp2RKhBDwIPjhFLJEPpjV7PkE1WVmkbrgf4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z1cGLUJkthttde2B/DWMgObQOkR+5ykmjcOMSfBoypeeAVq5fpagvGRd5+pNpsMzZvMHuUba5DR2M8NpY9tu4XVz5ue1+241ZHtB9Nrd35JzHsorbzgPwfGYsoJhSmFlUcs6ZbXm9gCfg886wbJq5O1s6KCJ+oztm4l+XOabfWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Abgo5lh/; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Abgo5lh/" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-b551b040930so4637975a12.2 for ; Wed, 01 Oct 2025 01:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759306268; x=1759911068; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9sp3cgB81mX5j3kEpDMGkvj6tFo6ebH1h3lg6uJz188=; b=Abgo5lh/JCCIIue5wdaD9BskXSeuDy8PRlNm1hDR209mYk/UtT/Uj0pTBC9Mfc152x 48Xp1WVnUe6AUwbO063ozdnTX1QL/9vaiiFj+ABlkdlAII439wy16D4kgPZG2r2isW/x 0og96lgLCugtrfp238+GVdiOjc9JNnZOgzXv7yd8+AVdW5ANGMXIewo/VPc+IDwnongB HYvI5KHv3gMPmcUs223YrbTO+c9qKuD+LTNDmRuyCCpbVoyX1S/nPithBGbS7dqaSWsb 32ZoE2xW+Z1CphlsV9YdLvyhN0RgMJt7XTkLAWMKrAMB59M+aVYUNVwBV0nQmVxWeSNK DD8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759306268; x=1759911068; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9sp3cgB81mX5j3kEpDMGkvj6tFo6ebH1h3lg6uJz188=; b=w1e3xPsVr83b6OUP4sQdgZSXQOguXn8Wv5tOqpoKYojYBIE8fk8ubrhIx5lQVesGSk 1rt4XqotF2bDaOnE7KXnzRpdAgATyx/8mnpwypXSwFEDfX0rfmGRKo4b5nmJrcus+ZIr Q9ttQVyDX6Suwvi120FUkydEzFkTVWEGhgFJBGMDHxkfvIGVjvRNnWtqqucP55uij/a8 Btgn/bVHwGnV6yPu+2Fc5bh93jkv0dYGC+XCYQoJ9wdLB4Sb+tIjn0OpbSGHcJXUt1yg Ps16E5eK72EFVLRiQqpa/8c2VvDUQI/Jsk6ImQmYd0Pro12ZlMOw4GKQH9wzrmL4twzi 5vFw== X-Forwarded-Encrypted: i=1; AJvYcCUGSnILf/zemIgoY7nQtoYjR3n9K3DtrMasxphLfEFyDZkoHVXKBCkI9a+ddoVnW9LTCyVYBN0Z0L4=@vger.kernel.org X-Gm-Message-State: AOJu0YyNf4RLdsvlyG18Yk63pQHdzlDKFFlKwC8z8AosuT78ID9S+eCi oOBeupbemPnQoBoEwpJJQMlfOp49V9XY2nTRkeIXhYHxVB9gyfUe7kw6 X-Gm-Gg: ASbGncu72qZqgtuXKz0sfwrQj8d+/7+vi+fsrV9fFHKZPzgm7c9e6yEfKjCmPApZXy3 mbdDc3Ow2ig1MTmN87VR5Uk5aWxVokxHojwgqHkCJs1FrXgxyjvGHeoR7RzS0MN0pclFLY/BTSz UpDCDJmlVMoYvg/XHfJSt9yhic13QV9k5z2KsfTX1hA5ILIh0zIpboxcH1ujN8YDwemEm6FCIG0 Qj/j7l+PUnzXovFGhy9KoYhr3bPmNR9RqpUnm4+PTl/2UXemP4niuLYX+0ZIhz9/JllYA+6tXkK TqKaoYj0Wv+BUDBu1fq5GBY5LOLxN6Fwgm+Ik/Es4KRAPYTlww8ornX4cJEeASy5pr5cKV/rPF+ 18IrKNsfmZkpPx9gyoOzD8I+jZq+oOGczuXFhuSuztut8Vw3TdOnAsjvZKGcA6PybbRA4ng== X-Google-Smtp-Source: AGHT+IHupIF/aqS/uN1p6eF0m90zcA2AmdFfz6VwfCnH2eMPOA8mf1cKet57vjwVNF8IksMnMrnXfQ== X-Received: by 2002:a17:903:9ce:b0:272:1320:121f with SMTP id d9443c01a7336-28e7f332d05mr39109295ad.27.1759306268561; Wed, 01 Oct 2025 01:11:08 -0700 (PDT) Received: from [10.0.2.15] ([157.50.93.46]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3399c0b24eesm2038496a91.1.2025.10.01.01.11.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Oct 2025 01:11:08 -0700 (PDT) Message-ID: Date: Wed, 1 Oct 2025 13:40:56 +0530 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: usb: lan78xx: Fix lost EEPROM read timeout error(-ETIMEDOUT) in lan78xx_read_raw_eeprom To: Oleksij Rempel Cc: Jakub Kicinski , Thangaraj.S@microchip.com, Rengarajan.S@microchip.com, UNGLinuxDriver@microchip.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+62ec8226f01cb4ca19d9@syzkaller.appspotmail.com References: <20250930084902.19062-1-bhanuseshukumar@gmail.com> <20250930173950.5d7636e2@kernel.org> <5f936182-6a69-4d9a-9cec-96ec93aab82a@gmail.com> Content-Language: en-US From: Bhanu Seshu Kumar Valluri In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 01/10/25 13:12, Oleksij Rempel wrote: > Hi, > > On Wed, Oct 01, 2025 at 10:07:21AM +0530, Bhanu Seshu Kumar Valluri wrote: >> On 01/10/25 06:09, Jakub Kicinski wrote: >>> On Tue, 30 Sep 2025 14:19:02 +0530 Bhanu Seshu Kumar Valluri wrote: >>>> + if (dev->chipid == ID_REV_CHIP_ID_7800_) { >>>> + int rc = lan78xx_write_reg(dev, HW_CFG, saved); >>>> + /* If USB fails, there is nothing to do */ >>>> + if (rc < 0) >>>> + return rc; >>>> + } >>>> + return ret; >>> >>> I don't think you need to add and handle rc here separately? >>> rc can only be <= so save the answer to ret and "fall thru"? >> >> The fall thru path might have been reached with ret holding EEPROM read timeout >> error status. So if ret is used instead of rc it might over write the ret with 0 when >> lan78xx_write_reg returns success and timeout error status would be lost. > > Ack, I see. It may happen if communication with EEPROM will fail. The same > would happen on write path too. Is it happened with real HW or it is > some USB emulation test? For me it is interesting why EEPROM is timed > out. The sysbot's log with message "EEPROM read operation timeout" confirms that EEPROM read timeout occurring. I tested the same condition on EVB-LAN7800LC by simulating timeout during probe. Thanks.