From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C1AAC77B61 for ; Mon, 24 Apr 2023 23:30:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232846AbjDXXal (ORCPT ); Mon, 24 Apr 2023 19:30:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232966AbjDXXaf (ORCPT ); Mon, 24 Apr 2023 19:30:35 -0400 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D6EA46A9; Mon, 24 Apr 2023 16:30:26 -0700 (PDT) Received: from [IPV6:2408:824e:f25:7460:b092:16d8:698e:4b1a] ([172.16.0.254]) (user=dzm91@hust.edu.cn mech=PLAIN bits=0) by mx1.hust.edu.cn with ESMTP id 33ONTtLx029003-33ONTtM0029003 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 25 Apr 2023 07:29:56 +0800 Message-ID: Date: Tue, 25 Apr 2023 07:29:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH RESEND] usb: dwc3: remove dead code in dwc3_otg_get_irq To: Thinh Nguyen , lihuya Cc: Greg Kroah-Hartman , "hust-os-kernel-patches@googlegroups.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20230424105930.49944-1-lihuya@hust.edu.cn> <20230424213339.avocjfchjd2ptaqg@synopsys.com> From: Dongliang Mu In-Reply-To: <20230424213339.avocjfchjd2ptaqg@synopsys.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-FEAS-AUTH-USER: dzm91@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 2023/4/25 05:33, 'Thinh Nguyen' via HUST OS Kernel Contribution wrote: > On Mon, Apr 24, 2023, lihuya wrote: >> platform_get_irq() only return non-zero irq number on success, or >> negative error number on failure. >> >> There is no need to check the return value of platform_get_irq() >> to determine the return value of dwc3_otg_get_irq(), removing >> them to solve this problem. >> >> Signed-off-by: lihuya > Is this your full name? Hi Yuhang, Please use your full name: Yuhang Liang. This is essential in the kernel patch submission. Dongliang Mu > >> --- >> drivers/usb/dwc3/drd.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c >> index 039bf241769a..c2e09700212d 100644 >> --- a/drivers/usb/dwc3/drd.c >> +++ b/drivers/usb/dwc3/drd.c >> @@ -154,11 +154,6 @@ static int dwc3_otg_get_irq(struct dwc3 *dwc) >> goto out; >> >> irq = platform_get_irq(dwc3_pdev, 0); >> - if (irq > 0) >> - goto out; >> - >> - if (!irq) >> - irq = -EINVAL; >> >> out: >> return irq; >> -- >> 2.34.1 >> > FWIW, here's the ack again. > > Acked-by: Thinh Nguyen > > Thanks, > Thinh >