From: Birger Koblitz <mail@birger-koblitz.de>
To: Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/2] r8152: Add support for the RTL8157 hardware
Date: Tue, 24 Mar 2026 18:00:07 +0100 [thread overview]
Message-ID: <eb941ea7-4bca-457f-9a40-5300affe7e8e@birger-koblitz.de> (raw)
In-Reply-To: <5ff51617-deb6-48b0-b9e2-2d7066fa2562@redhat.com>
On 24/03/2026 11:58 am, Paolo Abeni wrote:
> On 3/20/26 12:14 PM, Birger Koblitz wrote:
>> @@ -2022,14 +2277,14 @@ static void intr_callback(struct urb *urb)
>> }
>> }
>>
>> -static inline void *rx_agg_align(void *data)
>> +static inline void *rx_agg_align(struct r8152 *tp, void *data)
>> {
>> - return (void *)ALIGN((uintptr_t)data, RX_ALIGN);
>> + return (void *)ALIGN((uintptr_t)data, tp->rx_desc.align);
>> }
>>
>> -static inline void *tx_agg_align(void *data)
>> +static inline void *tx_agg_align(struct r8152 *tp, void *data)
>
> Since you are touching this functions, in the next revision please
> additionally drop the 'inline' keyword; the compiler should be good
> enough to get them inlined anyway.
Will be fixed in the next version.
prev parent reply other threads:[~2026-03-24 17:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 11:14 [PATCH net-next v3 0/2] r8152: Add support for the RTL8157 5Gbit USB Ethernet chip Birger Koblitz
2026-03-20 11:14 ` [PATCH net-next v3 1/2] r8152: Add support for 5Gbit Link Speeds and EEE Birger Koblitz
2026-03-24 10:55 ` [net-next,v3,1/2] " Paolo Abeni
2026-03-24 15:49 ` Birger Koblitz
2026-03-20 11:14 ` [PATCH net-next v3 2/2] r8152: Add support for the RTL8157 hardware Birger Koblitz
2026-03-24 10:55 ` [net-next,v3,2/2] " Paolo Abeni
2026-03-24 16:55 ` Birger Koblitz
2026-03-24 10:58 ` [PATCH net-next v3 2/2] " Paolo Abeni
2026-03-24 17:00 ` Birger Koblitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb941ea7-4bca-457f-9a40-5300affe7e8e@birger-koblitz.de \
--to=mail@birger-koblitz.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox