Linux USB
 help / color / mirror / Atom feed
From: "Wu. JackBB (GSM)" <JackBB_Wu@compal.com>
To: Lars Melin <larsm17@gmail.com>, Johan Hovold <johan@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [External Mail] Re: [PATCH] USB: serial: option: add new usb-id for Dell Wireless DW5826e-m
Date: Thu, 4 Jun 2026 02:06:43 +0000	[thread overview]
Message-ID: <ec2181152ebc46adb68fcea2802aea15@compal.com> (raw)
In-Reply-To: <659c740c-66cc-41c6-8bc8-6d6ef1b5ab08@gmail.com>

> On 2026-06-01 09:52, Jack Wu via B4 Relay wrote:
> > From: Jack Wu <jackbb_wu@compal.com>
> >
> > Add support for Dell DW5826e-m with USB-id 0x413c:0x81ea
> >
> > T: Bus=03 Lev=01 Prnt=01 Port=04 Cnt=01 Dev#= 8 Spd=480 MxCh= 0
> > D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1
> > P: Vendor=413c ProdID=81ea Rev= 5.04
> > S: Manufacturer=DELL
> > S: Product=DW5826e-m Qualcomm Snapdragon X12 Global LTE-A
> > S: SerialNumber=358988870177734
> > C:* #Ifs= 7 Cfg#= 1 Atr=a0 MxPwr=500mA
> > A: FirstIf#=12 IfCount= 2 Cls=02(comm.) Sub=0e Prot=00
> > I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option
> > E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:* If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=usbfs
> > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=60 Driver=option
> > E: Ad=84(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
> > E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option
> > E: Ad=86(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
> > E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:* If#= 4 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
> > E: Ad=87(I) Atr=03(Int.) MxPS= 64 Ivl=32ms
> > I:* If#=12 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=0e Prot=00 Driver=cdc_mbim
> > E: Ad=88(I) Atr=03(Int.) MxPS= 64 Ivl=32ms
> > I: If#=13 Alt= 0 #EPs= 0 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim
> > I:* If#=13 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim
> > E: Ad=8e(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E: Ad=0f(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> >
> > Signed-off-by: Jack Wu <jackbb_wu@compal.com>
> > ---
> > drivers/usb/serial/option.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > index 48ae0188f2e9..e37013a6956a 100644
> > --- a/drivers/usb/serial/option.c
> > +++ b/drivers/usb/serial/option.c
> > @@ -203,6 +203,8 @@ static void option_instat_callback(struct urb *urb);
> > #define DELL_PRODUCT_5829E_ESIM 0x81e4
> > #define DELL_PRODUCT_5829E 0x81e6
> >
> > +#define DELL_PRODUCT_DW5826E_ESIM 0x81ea
> > +
> > #define DELL_PRODUCT_FM101R_ESIM 0x8213
> > #define DELL_PRODUCT_FM101R 0x8215
> >
> > @@ -1125,6 +1127,7 @@ static const struct usb_device_id option_ids[] = {
> > .driver_info = RSVD(0) | RSVD(6) },
> > { USB_DEVICE_INTERFACE_CLASS(DELL_VENDOR_ID, DELL_PRODUCT_FM101R, 0xff) },
> > { USB_DEVICE_INTERFACE_CLASS(DELL_VENDOR_ID, DELL_PRODUCT_FM101R_ESIM, 0xff)
> > },
> > + { USB_DEVICE_INTERFACE_CLASS(DELL_VENDOR_ID, DELL_PRODUCT_DW5826E_ESIM,
> > 0xff) },
> > { USB_DEVICE(ANYDATA_VENDOR_ID, ANYDATA_PRODUCT_ADU_E100A) }, /* ADU-E100,
> > ADU-310 */
> > { USB_DEVICE(ANYDATA_VENDOR_ID, ANYDATA_PRODUCT_ADU_500A) },
> > { USB_DEVICE(ANYDATA_VENDOR_ID, ANYDATA_PRODUCT_ADU_620UW) },
> >
> > ---
> > base-commit: e43ffb69e0438cddd72aaa30898b4dc446f664f8
> > change-id: 20260601-dw5826e-option-driver-e9bac038e2b5
> >
> > Best regards,
> > --
> > Jack Wu <jackbb_wu@compal.com>
> >
> >
> >
> Hi Jack,
> you have the device in the correct driver now and you have got rid of
> the legal disclaimer but there is still a problem with the patch.
> Interface #1 which is for ADB should not be claimed by the option
> driver, you have to add a line blacklisting (reserving)it.
>
> thanks
> Lars

Hi Lars,

Thanks for your review and pointing that out.

I will fix this by changing the entry to use USB_DEVICE_AND_INTERFACE_INFO with RSVD(1) to blacklist interface #1 (ADB).
I'll submit the v2 patch shortly.

Thanks.


================================================================================================================================================================
This message may contain information which is private, privileged or confidential of Compal Electronics, Inc. If you are not the intended recipient of this message, please notify the sender and destroy/delete the message. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon this information, by persons or entities other than the intended recipient is prohibited.
================================================================================================================================================================

      reply	other threads:[~2026-06-04  2:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01  2:52 [PATCH] USB: serial: option: add new usb-id for Dell Wireless DW5826e-m Jack Wu via B4 Relay
2026-06-02  6:47 ` Lars Melin
2026-06-04  2:06   ` Wu. JackBB (GSM) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec2181152ebc46adb68fcea2802aea15@compal.com \
    --to=jackbb_wu@compal.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=larsm17@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox