From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pin-yen Lin <treapking@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
linux-kernel@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: Add binding for PS5511 hub controller
Date: Wed, 9 Apr 2025 08:06:21 +0200 [thread overview]
Message-ID: <edc3cc2b-20a9-4175-9434-184485ea345f@kernel.org> (raw)
In-Reply-To: <CAEXTbpf9crpkTGctoWseoG1fz=jvUbiTi6e2adZy0JJu78dTgg@mail.gmail.com>
On 08/04/2025 06:30, Pin-yen Lin wrote:
>>> + peer-hub:
>>> + $ref: /schemas/types.yaml#/definitions/phandle
>>> + description:
>>> + phandle to the peer hub on the controller.
>>> +
>>> + ports:
>>> + $ref: /schemas/graph.yaml#/properties/ports
>>
>> I don't understand why do you need OF graph here. Children are already
>> defined in patternProperties as usb-devices.
>
> I would like to describe the connection between the hub and the USB
> connectors, which is similar to commit c44d9dab31d6a9 ("dt-bindings:
> usb: Add downstream facing ports to realtek binding").
>
> I'm aware that Rob expects a usb-hub.yaml binding in [1]. Should I do that now?
Yes, please, two devices using common pattern is already enough to
create common schema.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-04-09 6:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 8:28 [PATCH 1/2] dt-bindings: usb: Add binding for PS5511 hub controller Pin-yen Lin
2025-03-28 8:28 ` [PATCH 2/2] usb: misc: onboard_usb_dev: Add Parade PS5511 hub support Pin-yen Lin
2025-03-31 8:09 ` [PATCH 1/2] dt-bindings: usb: Add binding for PS5511 hub controller Krzysztof Kozlowski
2025-04-08 4:30 ` Pin-yen Lin
2025-04-09 6:06 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edc3cc2b-20a9-4175-9434-184485ea345f@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
--cc=treapking@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox