From: Shuah Khan <skhan@linuxfoundation.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-kernel@vger.kernel.org
Cc: Duncan Sands <duncan.sands@free.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Richard Leitner <richard.leitner@skidata.com>,
Alan Stern <stern@rowland.harvard.edu>,
Guenter Roeck <linux@roeck-us.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] usb: move from strlcpy with unused retval to strscpy
Date: Thu, 18 Aug 2022 15:17:40 -0600 [thread overview]
Message-ID: <edda5842-fa82-dfb0-b4b2-14a83673ea6c@linuxfoundation.org> (raw)
In-Reply-To: <20220818210116.7517-1-wsa+renesas@sang-engineering.com>
On 8/18/22 3:01 PM, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
Please elaborate and summarize why this change makses sense in the
commit log? It will be easier for reviewers - saves time checking
the link.
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/usb/atm/usbatm.c | 2 +-
> drivers/usb/core/devio.c | 2 +-
> drivers/usb/gadget/function/f_fs.c | 2 +-
> drivers/usb/gadget/function/f_uvc.c | 2 +-
> drivers/usb/gadget/function/u_ether.c | 8 ++++----
> drivers/usb/gadget/function/uvc_v4l2.c | 6 +++---
> drivers/usb/gadget/udc/omap_udc.c | 2 +-
> drivers/usb/misc/usb251xb.c | 6 +++---
> drivers/usb/storage/onetouch.c | 2 +-
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> drivers/usb/usbip/stub_main.c | 2 +-
I don't have any problems with the change itself. I would ike to
see the commit log clealrly state why this change is good. With
that for usbip change:
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
next prev parent reply other threads:[~2022-08-18 21:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 21:01 [PATCH] usb: move from strlcpy with unused retval to strscpy Wolfram Sang
2022-08-18 21:17 ` Shuah Khan [this message]
2022-08-19 5:47 ` Wolfram Sang
2022-08-18 22:08 ` Laurent Pinchart
2022-08-19 5:31 ` Richard Leitner
2022-08-19 9:09 ` Greg Kroah-Hartman
2022-08-24 19:56 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edda5842-fa82-dfb0-b4b2-14a83673ea6c@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=duncan.sands@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=richard.leitner@skidata.com \
--cc=shuah@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=valentina.manea.m@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox