From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="YM44BhIk" Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 775D88E; Tue, 28 Nov 2023 06:44:51 -0800 (PST) Received: from notapiano (cola.collaboradmins.com [IPv6:2a01:4f8:1c1c:5717::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 8FC1F66072A7; Tue, 28 Nov 2023 14:44:47 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701182690; bh=Og082W+PSa4+5mTtMkeABO/eaXozRb0GXaqspZ1T4tk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YM44BhIk4AoBxZhrTRTnU7Agoo7aoXPbUC+kkVuglrVw1oxHaC3sN8xCREdcJsw06 nkr38YpWD1IqnnPUZg0U1xrL42f2YkAagOaXzZbmapAdkdOOKx72TS7W6/NKBrQdGi pSdVYBGbsAOUQmzKiYu686WEzswrT9EmB4QGR734x0tqIM5IVwVMJkIlN9wWe8M1Zf QUEA1zCVt8AMmHKT4XbcFIJlEqyaQI+ygZlTOWLpatmlemGPx8hz/ZtFkBWT4zx/FP k+trbQUknlfB3LDKn9G2JLuIf7r5XxE8bJy3BSPLEmHviNzpgOMQZ1rYkKOJOV5FUA SSysqpsfwHfrA== Date: Tue, 28 Nov 2023 09:43:53 -0500 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: "Bird, Tim" Cc: Shuah Khan , Greg Kroah-Hartman , Bjorn Helgaas , Saravana Kannan , Rob Herring , "kernelci@lists.linux.dev" , David Gow , Guenter Roeck , "linux-kselftest@vger.kernel.org" , "linux-usb@vger.kernel.org" , "kernel@collabora.com" , Dan Carpenter , "linux-pci@vger.kernel.org" , Doug Anderson , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH v2 2/2] kselftest: devices: Add sample board file for google,spherion Message-ID: References: <20231127233558.868365-1-nfraprado@collabora.com> <20231127233558.868365-3-nfraprado@collabora.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Nov 28, 2023 at 12:10:46AM +0000, Bird, Tim wrote: > > -----Original Message----- > > From: Nícolas F. R. A. Prado > > Add a sample board file describing the file's format and with the list > > of devices expected to be probed on the google,spherion machine as an > > example. > > > > Signed-off-by: Nícolas F. R. A. Prado > > --- > > > > (no changes since v1) > > > > .../testing/selftests/devices/boards/google,spherion | 12 ++++++++++++ > > Overall, while trying to maintain a comprehensive set of board definitions > seems hard, I think having a few as examples is useful. > > I'm not a big fan of naming these with a comma in the name. Is there a reason > you are not using dash or underscore? I'm using the name that we get from the DT compatible, so the right file can be automatically selected by the test. > > Do you anticipate a convention of tuples for > the filename? I'd just stick to the DT compatible as it's the simplest option and should work just the same, assuming I understood correctly what you mean. Thanks, Nícolas