From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usbip: Fix misuse of strncpy() From: Shuah Khan Message-Id: Date: Tue, 24 Jul 2018 11:04:12 -0600 To: Ben Hutchings , Valentina Manea Cc: linux-usb@vger.kernel.org, Shuah Khan List-ID: T24gMDcvMjAvMjAxOCAwODoxMiBQTSwgQmVuIEh1dGNoaW5ncyB3cm90ZToKPiBnY2MgOCByZXBv cnRzOgo+IAo+IHVzYmlwX2RldmljZV9kcml2ZXIuYzogSW4gZnVuY3Rpb24g4oCYcmVhZF91c2Jf dnVkY19kZXZpY2XigJk6Cj4gdXNiaXBfZGV2aWNlX2RyaXZlci5jOjEwNjoyOiBlcnJvcjog4oCY c3RybmNweeKAmSBzcGVjaWZpZWQgYm91bmQgMjU2IGVxdWFscyBkZXN0aW5hdGlvbiBzaXplIFst V2Vycm9yPXN0cmluZ29wLXRydW5jYXRpb25dCj4gICBzdHJuY3B5KGRldi0+cGF0aCwgcGF0aCwg U1lTRlNfUEFUSF9NQVgpOwo+ICAgXn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fgo+IHVzYmlwX2RldmljZV9kcml2ZXIuYzoxMjU6MjogZXJyb3I6IOKAmHN0cm5jcHnigJkg c3BlY2lmaWVkIGJvdW5kIDMyIGVxdWFscyBkZXN0aW5hdGlvbiBzaXplIFstV2Vycm9yPXN0cmlu Z29wLXRydW5jYXRpb25dCj4gICBzdHJuY3B5KGRldi0+YnVzaWQsIG5hbWUsIFNZU0ZTX0JVU19J RF9TSVpFKTsKPiAgIF5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ Cj4gCj4gSSdtIG5vdCBjb252aW5jZWQgaXQgbWFrZXMgc2Vuc2UgdG8gdHJ1bmNhdGUgdGhlIGNv cGllZCBzdHJpbmdzIGhlcmUsCj4gYnV0IHNpbmNlIHdlJ3JlIGFscmVhZHkgZG9pbmcgc28gbGV0 J3MgZW5zdXJlIHRoZXkncmUgc3RpbGwgbnVsbC0KPiB0ZXJtaW5hdGVkLiAgV2UgY2FuJ3QgZWFz aWx5IHVzZSBzdHJsY3B5KCkgaGVyZSwgc28gdXNlIHNucHJpbnRmKCkuCj4gCj4gdXNiaXBfY29t bW9uLmMgaGFzIHRoZSBzYW1lIHByb2JsZW0uCj4gCj4gU2lnbmVkLW9mZi1ieTogQmVuIEh1dGNo aW5ncyA8YmVuQGRlY2FkZW50Lm9yZy51az4KPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+ IC0tLQo+ICB0b29scy91c2IvdXNiaXAvbGlic3JjL3VzYmlwX2NvbW1vbi5jICAgICAgICB8ICAg IDQgKystLQo+ICB0b29scy91c2IvdXNiaXAvbGlic3JjL3VzYmlwX2RldmljZV9kcml2ZXIuYyB8 ICAgIDQgKystLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlv bnMoLSkKPiAKPiAtLS0gYS90b29scy91c2IvdXNiaXAvbGlic3JjL3VzYmlwX2NvbW1vbi5jCj4g KysrIGIvdG9vbHMvdXNiL3VzYmlwL2xpYnNyYy91c2JpcF9jb21tb24uYwo+IEBAIC0yMjYsOCAr MjI2LDggQEAgaW50IHJlYWRfdXNiX2RldmljZShzdHJ1Y3QgdWRldl9kZXZpY2UgKgo+ICAJcGF0 aCA9IHVkZXZfZGV2aWNlX2dldF9zeXNwYXRoKHNkZXYpOwo+ICAJbmFtZSA9IHVkZXZfZGV2aWNl X2dldF9zeXNuYW1lKHNkZXYpOwo+ICAKPiAtCXN0cm5jcHkodWRldi0+cGF0aCwgIHBhdGgsICBT WVNGU19QQVRIX01BWCk7Cj4gLQlzdHJuY3B5KHVkZXYtPmJ1c2lkLCBuYW1lLCBTWVNGU19CVVNf SURfU0laRSk7Cj4gKwlzbnByaW50Zih1ZGV2LT5wYXRoLCBTWVNGU19QQVRIX01BWCwgIiVzIiwg cGF0aCk7Cj4gKwlzbnByaW50Zih1ZGV2LT5idXNpZCwgU1lTRlNfQlVTX0lEX1NJWkUsICIlcyIs IG5hbWUpOwoKSSBhbSBva2F5IHdpdGggdGhlIGNoYW5nZSB0byB1c2Ugc25wcmludGYoKS4gUGxl YXNlIGFkZCBjaGVjayBmb3IKcmV0dXJuIHRvIGF2b2lkIEdDQyA3IC1XZm9ybWF0LW92ZXJmbG93 IHdhbnJzIG9uIHNucHJpbnRmIGluc3RhbmNlcwp0aGF0IGRvbid0IGNoZWNrIHJldHVybi4KCj4g IAo+ICAJc3NjYW5mKG5hbWUsICIldS0ldSIsICZidXNudW0sICZkZXZudW0pOwo+ICAJdWRldi0+ YnVzbnVtID0gYnVzbnVtOwo+IC0tLSBhL3Rvb2xzL3VzYi91c2JpcC9saWJzcmMvdXNiaXBfZGV2 aWNlX2RyaXZlci5jCj4gKysrIGIvdG9vbHMvdXNiL3VzYmlwL2xpYnNyYy91c2JpcF9kZXZpY2Vf ZHJpdmVyLmMKPiBAQCAtMTAzLDcgKzEwMyw3IEBAIGludCByZWFkX3VzYl92dWRjX2RldmljZShz dHJ1Y3QgdWRldl9kZXYKPiAgCWNvcHlfZGVzY3JfYXR0cjE2KGRldiwgJmRlc2NyLCBpZFByb2R1 Y3QpOwo+ICAJY29weV9kZXNjcl9hdHRyMTYoZGV2LCAmZGVzY3IsIGJjZERldmljZSk7Cj4gIAo+ IC0Jc3RybmNweShkZXYtPnBhdGgsIHBhdGgsIFNZU0ZTX1BBVEhfTUFYKTsKPiArCXNucHJpbnRm KGRldi0+cGF0aCwgU1lTRlNfUEFUSF9NQVgsICIlcyIsIHBhdGgpOwo+ICAKPiAgCWRldi0+c3Bl ZWQgPSBVU0JfU1BFRURfVU5LTk9XTjsKPiAgCXNwZWVkID0gdWRldl9kZXZpY2VfZ2V0X3N5c2F0 dHJfdmFsdWUoc2RldiwgImN1cnJlbnRfc3BlZWQiKTsKPiBAQCAtMTIyLDcgKzEyMiw3IEBAIGlu dCByZWFkX3VzYl92dWRjX2RldmljZShzdHJ1Y3QgdWRldl9kZXYKPiAgCWRldi0+YnVzbnVtID0g MDsKPiAgCj4gIAluYW1lID0gdWRldl9kZXZpY2VfZ2V0X3N5c25hbWUocGxhdCk7Cj4gLQlzdHJu Y3B5KGRldi0+YnVzaWQsIG5hbWUsIFNZU0ZTX0JVU19JRF9TSVpFKTsKPiArCXNucHJpbnRmKGRl di0+YnVzaWQsIFNZU0ZTX0JVU19JRF9TSVpFLCAiJXMiLCBuYW1lKTsKCkkgYW0gb2theSB3aXRo IHRoZSBjaGFuZ2UgdG8gdXNlIHNucHJpbnRmKCkuIFBsZWFzZSBhZGQgY2hlY2sgZm9yCnJldHVy biB0byBhdm9pZCBHQ0MgNyAtV2Zvcm1hdC1vdmVyZmxvdyB3YW5ycyBvbiBzbnByaW50ZiBpbnN0 YW5jZXMKdGhhdCBkb24ndCBjaGVjayByZXR1cm4uCgp0aGFua3MsCi0tIFNodWFoCi0tLQpUbyB1 bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGlu dXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVs Lm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9y ZG9tby1pbmZvLmh0bWwK