From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D729EC64E8A for ; Sun, 29 Nov 2020 16:39:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58A5220738 for ; Sun, 29 Nov 2020 16:39:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k8LJ3ofx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727706AbgK2QjQ (ORCPT ); Sun, 29 Nov 2020 11:39:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725468AbgK2QjO (ORCPT ); Sun, 29 Nov 2020 11:39:14 -0500 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28617C0613CF; Sun, 29 Nov 2020 08:38:34 -0800 (PST) Received: by mail-pf1-x441.google.com with SMTP id 131so8746558pfb.9; Sun, 29 Nov 2020 08:38:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=zHdDK+dmWn8gCx5N2jMxoQKX0RRPwzh45mj3hu0wPTI=; b=k8LJ3ofxbaEDXqtJqsn+MQmQ1WyUzQ8KBZqjnmOy4m8kugY0plvzl1PFPOHA8gtjdc Mo4EscHW48LGZHZhZSkKo4w3A2rCL5lf7/ZJgGrr/WcenDfctf+sguY1z+Xa0AJAT/HD CLtJfy8tG/b6sgbs3eYDxb/djbojTSoPG8gWGYYBcdfpSAsffG78LMIjKInE3lUtW1jJ GyChVnDgh+Jwfc2KVa19u9spWVo9yldmaynpbcCXPSIP9OZTgpdFhqDBNYbDzGTydOEE hlnxXhd4m38KFkClAgQMxIyf/ax52MZbIBkVTpXSF4GeRBB+EJZzuqTpFlraNaMpD/Q6 vGCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=zHdDK+dmWn8gCx5N2jMxoQKX0RRPwzh45mj3hu0wPTI=; b=nUdrhAcxJXJxfMcoGwFvMEpbJu559rITKj+dXajjwveLCaysx7yNxUtnMrNuGxVPJY hkjUw1leIfUjtPnAD4fj2FyFS+fOo9qV5PQ3jrpPtWpS74miKYGcimGoCLyC0f3PTRcc Mi5n++uhzSYHnc1IRPQX5VxihK5A1fiyjYyDWJDc/ze9gq12XFY35eOzuxgNQkJIQ3nA 0LWJeO86UAo3fOBSlIhPV10OVbFkAK0E6ieILxjE5R4H4hUqFc6gin0vhidO+KPhCX8a Tih45uWrhPjW/JxKCNyGP2IHRqONhaTg+ig9172rpAI3R7/pRbM3CraPVcYD0z9dRcFh HyGA== X-Gm-Message-State: AOAM531zJW3KfEiBjnyt1VDw5WHKuR8/pUkbykBefAWBrmG0e3CCVgod mm5UwC816TtQb1AzbACeKq8vGug922kF3fLuW5E= X-Google-Smtp-Source: ABdhPJyxIprkMw3TNMRFj6zBOvRavLjgksCcdNrTLnwuq9D3qq7Lzl6dAYIAxzhOt4a+LXZFJ3NMvg== X-Received: by 2002:a17:90a:f288:: with SMTP id fs8mr18371210pjb.184.1606667912972; Sun, 29 Nov 2020 08:38:32 -0800 (PST) Received: from [192.168.0.104] ([49.207.196.188]) by smtp.gmail.com with ESMTPSA id e8sm13876144pfj.157.2020.11.29.08.38.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Nov 2020 08:38:32 -0800 (PST) Subject: Re: [PATCH 03/15] usb: misc: cytherm: update to use usb_control_msg_recv() To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201129160612.1908074-1-anant.thazhemadam@gmail.com> <20201129160612.1908074-4-anant.thazhemadam@gmail.com> From: Anant Thazhemadam Message-ID: Date: Sun, 29 Nov 2020 22:08:29 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 29/11/20 9:46 pm, Greg Kroah-Hartman wrote: > There's no more need to dynamically allocate the buffer variable here > now, right? It can be on the stack as the change you made above allows > that to work properly, no need to allocate the buffer twice in a row > (once here and once in the USB core). > > That would make these functions less complex, always a good thing. > > You should check this on the other patches in this series as well. Understood, I will do that. I apologize for the oversight. Thanks, Anant