From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Miles Chen <miles.chen@mediatek.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Balamanikandan Gunasundar
<balamanikandan.gunasundar@microchip.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Dan Sneddon <dan.sneddon@microchip.com>
Cc: <linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] usb: gadget: at91_udc: fix incorrect print type
Date: Wed, 19 Jan 2022 11:52:43 +0800 [thread overview]
Message-ID: <eef429fa-d9d5-e0ea-8d19-45563fae27dc@mediatek.com> (raw)
In-Reply-To: <20220119020849.25732-1-miles.chen@mediatek.com>
On 1/19/22 10:08 AM, Miles Chen wrote:
> Fix a build error observed with ARCH=arm DEFCONFIG=allmodconfig build.
>
> drivers/usb/gadget/udc/at91_udc.h:174:42: error: format '%d' expects argument of type 'int', but argument 3 has type 'struct gpio_desc *' [-Werror=format=]
>
> Fixes: 4a555f2b8d31 ("usb: gadget: at91_udc: Convert to GPIO descriptors")
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> ---
> drivers/usb/gadget/udc/at91_udc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
> index dd0819df096e..9040a0561466 100644
> --- a/drivers/usb/gadget/udc/at91_udc.c
> +++ b/drivers/usb/gadget/udc/at91_udc.c
> @@ -1895,7 +1895,7 @@ static int at91udc_probe(struct platform_device *pdev)
> at91_vbus_irq, 0, driver_name, udc);
> if (retval) {
> DBG("request vbus irq %d failed\n",
> - udc->board.vbus_pin);
> + desc_to_gpio(udc->board.vbus_pin));
> goto err_unprepare_iclk;
> }
> }
>
Reviewed-by: Macpaul Lin <macpaul.lin@mediatek.com>
Thanks!
Macpaul Lin
prev parent reply other threads:[~2022-01-19 3:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 2:08 [PATCH] usb: gadget: at91_udc: fix incorrect print type Miles Chen
2022-01-19 3:52 ` Macpaul Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eef429fa-d9d5-e0ea-8d19-45563fae27dc@mediatek.com \
--to=macpaul.lin@mediatek.com \
--cc=alexandre.belloni@bootlin.com \
--cc=balamanikandan.gunasundar@microchip.com \
--cc=balbi@kernel.org \
--cc=dan.sneddon@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).