Re: [PATCH v4 2/3] gpio: Add Intel USBIO GPIO driver

[Hans de Goede <hansg@kernel.org>]

Hi,

On 10-Sep-25 11:41 PM, Linus Walleij wrote:
> Hi Hans,
> 
> thanks for your patch!
> 
> On Wed, Sep 10, 2025 at 3:40 PM Hans de Goede <hansg@kernel.org> wrote:
> 
>> From: Israel Cepeda <israel.a.cepeda.lopez@intel.com>
>>
>> Add a a driver for the GPIO auxbus child device of the Intel USBIO USB
>> IO-expander used by the MIPI cameras on various new (Meteor Lake and
>> later) Intel laptops.
>>
>> Co-developed-by: Hans de Goede <hansg@kernel.org>
>> Signed-off-by: Hans de Goede <hansg@kernel.org>
>> Signed-off-by: Israel Cepeda <israel.a.cepeda.lopez@intel.com>
> (...)
> 
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -1448,6 +1448,17 @@ config GPIO_LJCA
>>           This driver can also be built as a module. If so, the module
>>           will be called gpio-ljca.
>>
>> +config GPIO_USBIO
>> +       tristate "Intel USBIO GPIO support"
>> +       depends on USB_USBIO
>> +       default USB_USBIO
>> +       help
>> +         Select this option to enable GPIO driver for the INTEL
>> +         USBIO driver stack.
>> +
>> +         This driver can also be built as a module. If so, the module
>> +         will be called gpio_usbio.
> 
> This is in the wrong submenu (and the GPIO_LJCA is in the
> wrong place too, but that's not your problem...)
> 
> We have:
> 
> menu "USB GPIO expanders"
>         depends on USB
> 
> So put it in this submeny.
> 
> Other than that it looks good, so with that change:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Thank you, I'll fix this for v5 and add your R-b.

Regards,

Hans