linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karoly Pados <pados@pados.hu>
To: "Bjørn Mork" <bjorn@mork.no>, "Johan Hovold" <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Martyn Welch <martyn.welch@collabora.co.uk>
Subject: USB: serial: cp210x: Implement GPIO support for CP2102N
Date: Mon, 02 Jul 2018 19:17:33 +0000	[thread overview]
Message-ID: <f16a7de43b151c6f98ff5ff379427f16@pados.hu> (raw)

>> First of all I can't seem to find that code snippet on the wiki page it
>> does refer to, so I'm still not convinced.
> 
> It was there in older versions of the article. See for example:
> https://en.wikipedia.org/w/index.php?title=Fletcher's_checksum&oldid=730327006
> 
>> Second, this should have been high-lighted in your submission somehow.
> 
> Definitely. All code has an original author who deserves credit. And if
> you cannot find the original author, then there is always a risk than
> someone along the line stole the code... Maybe long before it ended up
> in Wikipedia. But that doesn't matter.
> 
> Doesn't seem worth the risk for a simple checksum algorithm which
> probably has lots of GPL implementations.
> 

Sorry about not explicitly mentioning the source, I only cared about making
sure that there is no violation and I thought that'd be enough.
Next time something like this happens, I'll explicitly name the sources
even if the license does not require it.

And just to clear things up further, rest assured that fletcher function was 
the only one copied from the Cypress knowledge base or from anywhere else.
Rest is by me, so there should be no other unclear origins.

On a different note, v2 patches are coming soon with the feedback from Johan
incorporated. Did not forget and I still intend to polish everything up
as requested to get these features into mainline.

Karoly
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-07-02 19:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 19:17 Karoly Pados [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-07-05 13:11 USB: serial: cp210x: Implement GPIO support for CP2102N Johan Hovold
2018-07-05 13:10 Johan Hovold
2018-07-05 13:09 Johan Hovold
2018-07-02 18:04 Bjørn Mork
2018-06-22 15:10 Martyn Welch
2018-06-20 19:41 Karoly Pados
2018-06-20 16:51 Martyn Welch
2018-06-20 10:52 Johan Hovold
2018-06-20  9:45 Karoly Pados
2018-06-20  8:25 Johan Hovold
2018-06-17 18:25 Karoly Pados

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f16a7de43b151c6f98ff5ff379427f16@pados.hu \
    --to=pados@pados.hu \
    --cc=bjorn@mork.no \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=martyn.welch@collabora.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).