From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D4F515853F for ; Thu, 1 Aug 2024 06:54:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722495264; cv=none; b=Uvl8HKNMNlYAE6Zy6RvNZ+KchdVK4qiUUULsW98av8pjwBOOzCg8T6bU5P5GoOdgQynNcfVz/fBhsrpgYu570k7niHafeO1eEXMvsQao1dXJR9mFRBGeOoo89pPVcs9ngyGDXIe/g2a+5OB3nnx24KqzzyZ8YdxyHC1A/vHRt2M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722495264; c=relaxed/simple; bh=B2aduLbyl2w0DOqap6opE0ZMrWyZxDEAiEjEX4uiR5w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZCAZg5uIdNTDDJuVfclDmmzArkgajeyQze2xQoHmBhgHMXIVxJC68IQRqDWzwGsrwdYA+e08mRkxL4TD0LTwU8dpjQ5XQv089/R/GjMHAuFXKw5qLTDZfmRPZPYWwPjCDrVxa7MYGbeGR/S0mK3oi/ZNdNegeXn6GkKC+8+kHAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=FEERfxEQ; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="FEERfxEQ" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5a2ffc346ceso9311462a12.1 for ; Wed, 31 Jul 2024 23:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1722495261; x=1723100061; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=REx9tnLqztn/PqERh1PtnQ3iEqlwlxeIi55PMWMtu0k=; b=FEERfxEQ4RIn+rBplsgkujG0yD77hyiEKA7BXH0DMxSTs1B/54wlSGL1o6DbKTXDT2 DUl1mkHHcBHT7nwMNDn3hV6rVsWdMDm55ABkJnwPBBzYwXTUxOtOJUXVvcCygMvoIcqc FWLWColyBrNUFk5fUmHFra8ejv8DkFD6aNAbSc0KMi+0WdY/VwEpqlCuhzWEbmydUF6b UdV+XJGxGiFqwRu+NRtOOtQy/tDKvrbMr6HgcLKVy97jbk5OujtsvldJYp+vVoX1VhUs 0liAJwTlcAwVOG0yrOmcPfhTyy/bE6NcI6zZD7iOAujsDesFdZmQ2nPctLKcc6U2lcOG dC4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722495261; x=1723100061; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=REx9tnLqztn/PqERh1PtnQ3iEqlwlxeIi55PMWMtu0k=; b=hwxRQVyWt9yLHxKyMGIVYMqDzo/CmwLQFAbT5uD7aYCrIvykh4i39HrckL1Tr3C8tM GNXPzUaWZRMbm9xLwDP36v0T0fYYRi5hdgwuNLOnMwqpGnMQPQ2BRqou/UWC5YuAVaCA HuZi5RfhwuJay+p9EKfbDXbS1OYnn8Wo9NpRUGPyXUiRN4Y5+v3pmTWrtcu4Q4oIb9dj iAMMI6f5G55RtFY+RxQNJ4irGfAt3Zmig6I401fnHsP1A8p4jmFF+dc/4ts7llvph2FF rt6mBRIsuhVKKmic1jihGVt+3hcHjibnENxuSCIFgSAvuC5ntHca8y+rLnIZZe+OtXKx JPjw== X-Forwarded-Encrypted: i=1; AJvYcCW/XSQ2vqmfsfS1HvORpUgzr0RSSbln5hOT6ypmuE2+fc5HqJkdfRqIpIyZcO9OyMKmYVKPbz4DBHLFmjN05i7bq1GyMk/IW8qi X-Gm-Message-State: AOJu0YzLvShJ3KH8c4pRy+qsiSEy8ieKsMYyYAPhEqi3o5Jjg3fVnhCU jsAJOtYOuCUYhJyl29URtv4P/v5N31GSzLHOrUr/UPKIdHvKeTZ6X+gxZB9bZ1w= X-Google-Smtp-Source: AGHT+IEx3GWmyFwZ41U1O+u9nI48xayCAcAUdP+Lr6251MaZzgfsFNonuaQsevOfxfxqTi9mkXxhsw== X-Received: by 2002:a17:907:724e:b0:a7a:a2e3:3734 with SMTP id a640c23a62f3a-a7daf2d5ca8mr93384466b.28.1722495260167; Wed, 31 Jul 2024 23:54:20 -0700 (PDT) Received: from ?IPV6:2001:a61:137b:5001:be5a:c750:b487:ff1b? ([2001:a61:137b:5001:be5a:c750:b487:ff1b]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acab53704sm856031766b.86.2024.07.31.23.54.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 23:54:19 -0700 (PDT) Message-ID: Date: Thu, 1 Aug 2024 08:54:18 +0200 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: storage: ene_ub6250: Fix right shift warnings To: Alan Stern , Abhishek Tamboli Cc: gregkh@linuxfoundation.org, oneukum@suse.com, usb-storage@lists.one-eyed-alien.net, linux-usb@vger.kernel.org, skhan@linuxfoundation.org, dan.carpenter@linaro.org, rbmarliere@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org References: <20240729182348.451436-1-abhishektamboli9@gmail.com> <5d7870b0-6b63-430b-8885-2509b33dc78a@suse.com> <804a6d40-73a4-4af6-944b-95e9324d7429@rowland.harvard.edu> Content-Language: en-US From: Oliver Neukum In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31.07.24 20:19, Alan Stern wrote: > On Wed, Jul 31, 2024 at 11:34:45PM +0530, Abhishek Tamboli wrote: >> On Wed, Jul 31, 2024 at 10:04:33AM -0400, Alan Stern wrote: Hi, I should make my reasoning clearer. >>> Replacing the variable with a constant won't make much difference. The >>> compiler will realize that bl_len has a constant value and will generate >>> appropriate code anyway. I think just changing the type is a fine fix. While that is absolutely true, it kind of removes the reason for the patch in the first place. The code gcc generates is unlikely to be changed. We are reacting to a warning an automatic tool generates. That is a good thing. We should have clean code. The question is how we react to such a report. It just seems to me that if we fix such a warning, the code should really be clean after that. Just doing the minimum that will make the checker shut up is no good. Regards Oliver