From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8B1A1C54B0 for ; Mon, 16 Dec 2024 05:54:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734328446; cv=none; b=B1NDUZJsWlG2oLPoVk6pYn0q3rOvUKi4C/G6rwiVR/gvoFtuOcC9yblYEUaS25N4IrK+fOLBEsFBcWbU6t+yzDIfW8Pqoop8/16wP2/YkEh1prjvOKDBAUjqi5R1ye0V5aH90SHE4t8NYJHs2udmn7OZ5+hmZLumcC4K6Re4I3M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734328446; c=relaxed/simple; bh=ZNP0v3/4BomZoAEvLGEv2cgm7ao+GyUKQDkAYpR1azM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=O+tUJEwn/EuuzY/da4rUfucPkQdYhvSKMolcY2goKte0m0N8/+H0LlzCc6qUpEbZ3c1MqVDBRQDkotOfd01jkHeeaY1PZAB7jfRy5B9S13neVGn7YeeaL4apJevlYGbM8H907n4D9yY1N0zXkJf3UwDmcjJuVgJKpcpYhWXMUnE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cXRPzalh; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cXRPzalh" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-aa69107179cso700844466b.0 for ; Sun, 15 Dec 2024 21:54:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734328443; x=1734933243; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=w+dFO3Ui/sEdU+d4tBQlNTeaAHc3ObDp+PAoFFR+kSQ=; b=cXRPzalhrzVQbg4p208Qo/iCamDAmiRORkhlNuTK2WsdFgrc3WFUxq4sVSQAWfnv12 RD5tOMZchdnE6g+9EdRbA3dtOlWRQvtKkEPULAU0/J5uGXjLu3Zy+XBaQNPDRYo+bkMd PC38nJZ8wCnchHRMcg0noF/hFxpVyIJbnAAcYGYnnQA2MKdP/b1NeZVsCxlAbaoPS2jP nsnuC0wCOjH0cONf+HAdfUesp96AIxXrJoqCpE1e5IqAANj1ZGW582oIMqlK3/r+dgjs V4fbugV33XHmQJ6eBw1EP4KDuZUqAJC/RFJZxFT2ZnRDDswnCmQJehVUyWLNiKIyXvoc e7pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734328443; x=1734933243; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w+dFO3Ui/sEdU+d4tBQlNTeaAHc3ObDp+PAoFFR+kSQ=; b=r7ziiIqJQ0oQl/HKcGNM40MX4+HNoePS9Xf//PLEeBNVYKox1FhTgJMKj3U/2XseFR WvafrAK6vEJ5REVKwuSv3wPB4QcgXBw83uP77a684IGDq/5GHKhfN882fkXWprEt5O8y s56NZWiUSiWPeGe0tEdffW/y1m5oADmLdu8jBHFzsz7Yg3PyiFStHbfzVlgGizufwIub YISzdsPWzbKupclBqbsIZLQqzQmQDoUvWHER9R5qy+8s65K69UcR1XERgMuW0k3xypPZ WvanxIaME/uQGTMdC/1Djaz5LL5MP24iWLpytREQpTcrbyukUCAEnmHqjAPZAWZsM1Na QYiA== X-Forwarded-Encrypted: i=1; AJvYcCWbzHop+eJzR2wOsdArOyoqnCiL3hzFz5+6V32XowfXQKBWuXNgDoqtwcAA7/SlPbdIM5UbAmtjLBs=@vger.kernel.org X-Gm-Message-State: AOJu0YwroCDAUg+sm6nrryghGGMO8JSa9cs7lnxpHonNG0xcaIUZixeZ FvSfuFnBfp57xzJYmWgGh2cqnj6cKuQa07YS/C6B+jfeI05CjgrpgodYWcTmN1Y= X-Gm-Gg: ASbGncvtEzeZ4D/WHNJ3NwuBBujDGOP56AAj/VWkvAwwD5FJ5uuv6cc+0LmnZKUxBrM QXYiWqEPtXz4V2ABo7nJq1FbNYexiXSfW7wUWB7RfF2/jqOsUYsQRdrYoBQAXATuIeiDxGgKhjn 0MuT7T7wYvCi3lijanNmDW8aUD2QuPh13TBO5iWSy1NpuhwlYVrp+09g5tXjvKUJjFV4nZ+vvE9 JywfU4lQGOOzkgSFDHnjEvCXmtTmKRmHENFiPt5CqyRnr+uQ9Uy+guE0lx2jQ== X-Google-Smtp-Source: AGHT+IFoSvWSFfIldErFNpAMajYw9cB5vCOVjo6HVzQrtAlbPuyC5xoikuxSZeInpDkydeS20+n9Qg== X-Received: by 2002:a17:907:7216:b0:aab:76bd:5f8e with SMTP id a640c23a62f3a-aab77ed35d6mr1120600366b.53.1734328443208; Sun, 15 Dec 2024 21:54:03 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aab96006c2fsm286466466b.9.2024.12.15.21.54.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2024 21:54:02 -0800 (PST) Date: Mon, 16 Dec 2024 08:53:59 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Vitalii Mordan , Greg Kroah-Hartman Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Vitalii Mordan , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Aaro Koskinen , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Fedor Pchelkin , Alexey Khoroshilov , Vadim Mutilin , stable@vger.kernel.org Subject: Re: [PATCH] usb: phy-tahvo: fix call balance for tu->ick handling routines Message-ID: Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241209152604.1918882-1-mordan@ispras.ru> Hi Vitalii, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Vitalii-Mordan/usb-phy-tahvo-fix-call-balance-for-tu-ick-handling-routines/20241209-232934 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing patch link: https://lore.kernel.org/r/20241209152604.1918882-1-mordan%40ispras.ru patch subject: [PATCH] usb: phy-tahvo: fix call balance for tu->ick handling routines config: alpha-randconfig-r072-20241215 (https://download.01.org/0day-ci/archive/20241215/202412150530.f03D8q1a-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 14.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202412150530.f03D8q1a-lkp@intel.com/ smatch warnings: drivers/usb/phy/phy-tahvo.c:347 tahvo_usb_probe() warn: passing zero to 'PTR_ERR' vim +/PTR_ERR +347 drivers/usb/phy/phy-tahvo.c 9ba96ae5074c9f Aaro Koskinen 2013-12-06 341 9ba96ae5074c9f Aaro Koskinen 2013-12-06 342 mutex_init(&tu->serialize); 9ba96ae5074c9f Aaro Koskinen 2013-12-06 343 125b175df62ecc Vitalii Mordan 2024-12-09 344 tu->ick = devm_clk_get_enabled(&pdev->dev, "usb_l4_ick"); 125b175df62ecc Vitalii Mordan 2024-12-09 345 if (!IS_ERR(tu->ick)) { ^ This typo breaks the driver. 125b175df62ecc Vitalii Mordan 2024-12-09 346 dev_err(&pdev->dev, "failed to get and enable clock\n"); 125b175df62ecc Vitalii Mordan 2024-12-09 @347 return PTR_ERR(tu->ick); 125b175df62ecc Vitalii Mordan 2024-12-09 348 } 9ba96ae5074c9f Aaro Koskinen 2013-12-06 349 9ba96ae5074c9f Aaro Koskinen 2013-12-06 350 /* 9ba96ae5074c9f Aaro Koskinen 2013-12-06 351 * Set initial state, so that we generate kevents only on state changes. 9ba96ae5074c9f Aaro Koskinen 2013-12-06 352 */ 9ba96ae5074c9f Aaro Koskinen 2013-12-06 353 tu->vbus_state = retu_read(rdev, TAHVO_REG_IDSR) & TAHVO_STAT_VBUS; 9ba96ae5074c9f Aaro Koskinen 2013-12-06 354 860d2686fda7e4 Chanwoo Choi 2015-07-01 355 tu->extcon = devm_extcon_dev_allocate(&pdev->dev, tahvo_cable); -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki