* usb: gadget: core: Fix use-after-free of usb_request
@ 2017-12-21 4:24 Manu Gautam
0 siblings, 0 replies; 2+ messages in thread
From: Manu Gautam @ 2017-12-21 4:24 UTC (permalink / raw)
To: Felipe Balbi; +Cc: linux-usb, Manu Gautam
Driver is tracing usb_request after freeing it.
Fix it by changing the order.
Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
---
drivers/usb/gadget/udc/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
index d41d07a..ab0a075 100644
--- a/drivers/usb/gadget/udc/core.c
+++ b/drivers/usb/gadget/udc/core.c
@@ -191,8 +191,8 @@ struct usb_request *usb_ep_alloc_request(struct usb_ep *ep,
void usb_ep_free_request(struct usb_ep *ep,
struct usb_request *req)
{
- ep->ops->free_request(ep, req);
trace_usb_ep_free_request(ep, req, 0);
+ ep->ops->free_request(ep, req);
}
EXPORT_SYMBOL_GPL(usb_ep_free_request);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* usb: gadget: core: Fix use-after-free of usb_request
@ 2018-01-31 5:25 Manu Gautam
0 siblings, 0 replies; 2+ messages in thread
From: Manu Gautam @ 2018-01-31 5:25 UTC (permalink / raw)
To: Felipe Balbi; +Cc: linux-usb
Hi Felipe,
On 12/21/2017 9:54 AM, Manu Gautam wrote:
> Driver is tracing usb_request after freeing it.
> Fix it by changing the order.
Let me know if following change looks ok?
>
> Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
> ---
> drivers/usb/gadget/udc/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
> index d41d07a..ab0a075 100644
> --- a/drivers/usb/gadget/udc/core.c
> +++ b/drivers/usb/gadget/udc/core.c
> @@ -191,8 +191,8 @@ struct usb_request *usb_ep_alloc_request(struct usb_ep *ep,
> void usb_ep_free_request(struct usb_ep *ep,
> struct usb_request *req)
> {
> - ep->ops->free_request(ep, req);
> trace_usb_ep_free_request(ep, req, 0);
> + ep->ops->free_request(ep, req);
> }
> EXPORT_SYMBOL_GPL(usb_ep_free_request);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-31 5:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-31 5:25 usb: gadget: core: Fix use-after-free of usb_request Manu Gautam
-- strict thread matches above, loose matches on Subject: below --
2017-12-21 4:24 Manu Gautam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).