From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBB178473 for ; Wed, 25 Oct 2023 14:25:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 78C4C189 for ; Wed, 25 Oct 2023 07:25:29 -0700 (PDT) Received: (qmail 495360 invoked by uid 1000); 25 Oct 2023 10:25:28 -0400 Date: Wed, 25 Oct 2023 10:25:28 -0400 From: Alan Stern To: "Li, Meng" Cc: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "usb-storage@lists.one-eyed-alien.net" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] usb: storage: add shutdown function for usb storage driver Message-ID: References: <20231023054111.2744872-1-Meng.Li@windriver.com> <33bd0779-bfe7-4c87-8fe6-ea8455df3b6b@rowland.harvard.edu> <3fe5b43c-a5aa-4c6a-8614-03a4d9dd53e2@rowland.harvard.edu> <2023102428-zit-quickness-9b73@gregkh> <5107f6ca-e972-4af1-a21d-6c95778969f3@rowland.harvard.edu> <2023102459-protector-frequency-1033@gregkh> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Oct 25, 2023 at 02:25:17AM +0000, Li, Meng wrote: > In fact, the reported error is not critical one. In my real work environment, there is not the error because there is not PCIe-TO-USB card installed on board. > The issue is reported to me from our tester who used the PCIe-TO-USB card to test the PCIe feature, not test USB feature. > I am ok to NAK this patch. The primary intention of sending this patch is to raise up the discussion about whether shutdown function should be added for usb mass storage driver, and I have got what I want. All right, then we will consider the issue closed. Thanks. Alan Stern