From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AD5836CDF8 for ; Thu, 8 Oct 2026 11:00:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791457257; cv=none; b=iPyY+gRApG5Fb49uTr0FAEyE8FKdeNG03V3OHZd8SC3gcZYrV3jjPsjHELrgJvtkvRplBasYT57et39Wr0RqP1EF4JOYrwZVt1uejQFhs0rhq5VlXAxdgPjUgQCNhqWVdHiqIGoLhWJ5t4JaxSj9EvCM9hchhtrFNJl60JX+NpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791457257; c=relaxed/simple; bh=Hv2/f9SdQ7Xo1WLsf5CXwfkJ7Dywol0sBld6LjtCz08=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y7dPW1afQFq2uexVm+rjb29ajKl+7KMaf3IrBLJU6aPXheDfZkYKntRKp6Oh8N6bypaUdYFYg2cfg4Vw3mTCGiOjQo2ZjvaawT9pGygpHhorfFw4F54L8TfssP6XFPF4MUMar4CoQiQGPHn4/brprZHiS+DjAAn+niFlQmSQmbg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=SqyRFPiM; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="SqyRFPiM" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4a180fbeef5so16903405e9.1 for ; Thu, 08 Oct 2026 04:00:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1791457254; x=1792062054; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=np5hFTibkx5z0+8RGGFNmawfN6ZXgeIigzCb4JmakuQ=; b=SqyRFPiMQFyoM7QgyoLSJ3PnzUj5kTwtig8YJeWiqwErn1EhO0d3kNXxdAB/xtRb4d hDPZqVHvXwjxTVuiIUO6K6riWZwBBp1XDdwSxnYx81dYOqtivCr8g6DJxeTvWfhZdh27 zf3E22/n0YqIFkzAngXVG4g5AFh4QETHvh4NBEKRgK8Jo7C3gNOUeRRz+6fEoScB/KLu H/WlvHC7LWRZhNlVskvaOJ07huYHtUV9tVekb9MMMllT/KLRnX8qDV4d30debBxp0u/d 9bXmEFjAm7BXumKJSswApqZwUz1HrFHtv565LDa1cGTH6AXXViZ40t1Q0xd2JH0RQH7Q mgpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791457254; x=1792062054; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=np5hFTibkx5z0+8RGGFNmawfN6ZXgeIigzCb4JmakuQ=; b=ejZblb7Ir5e5RpxH9FtvS18TqsMULVq1Qq8ntya09YRtl9J0Mp5YgQ6LZXrFQW+78W lmEJq6lO0fM6y+ineqsVcYr0MRx7hu51vvo3pruWMuGPiS3ApEJ4UScahWLiI6O03HgG uinyKhs9Q/74bFZMnNyIPLy8PT8T/2moDfymv9cnhtF/zEMgOWNwBwBtiZJihyPUaIni 4KBSPpsvQoTnQu0GEN8VyGlwaTbzSYQakskgRV8QKVkOz5cPpJh/FMUpFyr4zToEe6Fd E8xpcfhBYYGM7cQfR+Y5Hk5V5PGlzpDf1fipCqppxi3g9Gg2ete/LB2ku3fvI+CLKgKE LJAg== X-Forwarded-Encrypted: i=1; AKwUvByROGRjFKKrqI+Vwcv/NCJgcZ+Ku+GdjjnYNAzvnL+hAGI7/ZTQ0NTWgD8VU6bGBmmPwzG51n3VMFE=@vger.kernel.org X-Gm-Message-State: AFuF++kKnOtwIplrWPAW4iBC2FyT4YacCiaLAKVnMmqa1cdEMsmapWET Um5diggIdXbD4TK8zn4qSPknurLtFUcfvD1Rgor1angZ+6YHtCKNFAkIzp5iNPJBZBoXowVTT8M SZatO X-Gm-Gg: AYBFou0frHQ5+n6g9zSjEaPbfDolrdawsu6LhDPhB+M53FDGvvI/txuHFhaUj588Cvt /yMnSi4Bks6LTeBq/mFu/z5+o2T05Fa7FzwqxRBNdtoniDB6z/ba7LliTKok6L4YzQN5PqNzhkt dWocmPEgCUQAcdepb8rHLN2YJ8Dyv0y2wGEibTjzcig/hHOn+TOchzxWf3gRyNRxxpANpL0an83 BAdMM1UDfDjiC4IJmIogspW56L8cjINJk17DEgG86ck1lq/JnXsoTdEmbgXmvuS2o82yryM46M5 kQwfL27Fq81+FVPn9XaAdRTMjrFTDu0qJjJG5rIBP0pJbv4R0OGOPxoxQ0Rfn6072V99iyAIh1X lw3opVl1Ybg7DWLXXTii3oNs0fpbib4PmZy6RT7qEo70ZIQoVidKKTGyUdieuRrVU4rdFVkm2yE VsojxfHG6Ag/65/ufQJwOfiZMvPgg424yqODLXfFlJ+jkr8MuKoFdM6ipx7f03NLldDa37wEVUN q5NQ9UBOiATh3hIGLikcnGuY3GyE6Ea9U4K1yHbIQ== X-Received: by 2002:a05:600c:4e87:b0:49f:bd3c:bc18 with SMTP id 5b1f17b1804b1-4a18045565cmr89191725e9.19.1791457254152; Thu, 08 Oct 2026 04:00:54 -0700 (PDT) Received: from ?IPV6:2001:a61:13be:f901:8903:c5f1:e7c8:72f0? ([2001:a61:13be:f901:8903:c5f1:e7c8:72f0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1843cb256sm56466535e9.5.2026.10.08.04.00.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Oct 2026 04:00:53 -0700 (PDT) Message-ID: Date: Thu, 8 Oct 2026 13:00:53 +0200 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] usb: uas: implement .change_queue_depth to allow per-device queue depth override To: Luca Cecchi , linux-usb@vger.kernel.org Cc: linux-scsi@vger.kernel.org, oneukum@suse.com References: Content-Language: en-US From: Oliver Neukum In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Luca, On 04.10.26 13:41, Luca Cecchi wrote: > QUESTION > > Does this seem like a reasonable way to expose this, or would you rather Your patch is very good. Can you please resend it? It is a bit corrupted by the mailer. > see it handled differently (e.g. through the quirks table with a numeric > value instead of a boolean, if that fits the existing infrastructure > better)? Happy to adjust the implementation, rerun tests, or send more I would prefer both approaches. The reason I think that a udev rule is insufficient is that it inevitably leaves the window for a lockup to happen before udev can act. Could you also implement a quirk that limits queue depth to, let's say three quarters of the maximum? Regards Oliver