From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D42B2C433E0 for ; Thu, 18 Jun 2020 17:36:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0A2B207E8 for ; Thu, 18 Jun 2020 17:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592501803; bh=D8qTugg236Uw2hIurARpgyiSXWPaEXRNTLcF1pqY1a4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=KJjP/2xLg3WEgt7MyMtetI74KgxtaamCyf4EEAonDlzrzs517hmVHgQJFgLv1XqJ5 277rQ4znK63vA4471vWhGQQOW4iVdt7R6S4sV1kTqACReOUdCOR+FsgeXQt9Zojela XNpHJXI2No+OsK2zMuA+/AXPdmny6ORZvStqsxnw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732166AbgFRRgm (ORCPT ); Thu, 18 Jun 2020 13:36:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729533AbgFRRgl (ORCPT ); Thu, 18 Jun 2020 13:36:41 -0400 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEA90C06174E for ; Thu, 18 Jun 2020 10:36:41 -0700 (PDT) Received: by mail-ot1-x341.google.com with SMTP id d4so5204444otk.2 for ; Thu, 18 Jun 2020 10:36:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vSAKdupfjUnpQv7PVZTpVtSwPY/+63YsbAN25Eh8aLo=; b=GMzprk/8y3cOitItK+SVkpqGg8A/ZMra8JaEKJFMANat5jvqSWFNlHq5Q5MRgpHKQk 0nSqR41phZ4I+diI+SxDrGcHhAow3Igrv7jhP81S/JVMxmO/6ID6oGlfkwg4t4JLVp8j yBBBe6KVTIshDSBdeEoT9bhloJCCd7B5/UiE8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vSAKdupfjUnpQv7PVZTpVtSwPY/+63YsbAN25Eh8aLo=; b=YHI45nI5bNKCqi+R/0dj4r6d6MIBZ7gr2PMlZDBicVmFVqJ67plqinvuqdTmagw24M H3d+Nd+WEWdoUrN102yH7NmIjp6MfsvVfH/O3smemwKpCLgeBvqQdV0KOs1V9rSv+lNt 0qRuQ5ouSsO7fNbB8tz83PxjtoX9bpPYawkwufqBfwsmp5YuZkv8cDruTq5KbXK3eOrd oojmwxkfUMnzq66aRB0sQT//zzfUgi63A806Qsrz3GExo62uPQjvzuYBY4OMr5Ch9FpK LsCrKO7K2WHRSZJJZANDBl/WzeU/ZLtWRoBris/MlSmviCL3m4xKTC2nwuexnrn6hoEy /tGw== X-Gm-Message-State: AOAM530neU6609dyGbSuBUYRu7dmFfX5F20T8guNDZ9dp0/Pb9IVjb5s qDIwt8rwA9ZQvqPrsWDUO01XijKHP0E= X-Google-Smtp-Source: ABdhPJxbnv0wQeMddQlluY9O5pcY5u8TzvKuN4bf2b8PgHIYjZMViNvEKuwVnYxLt+tcNRzw9nnyYw== X-Received: by 2002:a9d:7b41:: with SMTP id f1mr4658243oto.363.1592501801252; Thu, 18 Jun 2020 10:36:41 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id g10sm836752otn.34.2020.06.18.10.36.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 10:36:40 -0700 (PDT) Subject: Re: [PATCH] usbip: tools: fix build error for multiple definition To: Antonio Borneo , Valentina Manea , Shuah Khan , Greg Kroah-Hartman , Hewenliang , linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org, skhan@linuxfoundation.org References: <20200618000844.1048309-1-borneo.antonio@gmail.com> From: Shuah Khan Message-ID: Date: Thu, 18 Jun 2020 11:36:39 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200618000844.1048309-1-borneo.antonio@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 6/17/20 6:08 PM, Antonio Borneo wrote: > With GCC 10, building usbip triggers error for multiple definition > of 'udev_context', in: > - libsrc/vhci_driver.c:18 and > - libsrc/usbip_host_common.c:27. > > Declare as extern the definition in libsrc/usbip_host_common.c. > > Signed-off-by: Antonio Borneo > --- > tools/usb/usbip/libsrc/usbip_host_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/usb/usbip/libsrc/usbip_host_common.c b/tools/usb/usbip/libsrc/usbip_host_common.c > index d1d8ba2a4a40..ca78aa368476 100644 > --- a/tools/usb/usbip/libsrc/usbip_host_common.c > +++ b/tools/usb/usbip/libsrc/usbip_host_common.c > @@ -23,7 +23,7 @@ > #include "list.h" > #include "sysfs_utils.h" > > -struct udev *udev_context; > +extern struct udev *udev_context; > > static int32_t read_attr_usbip_status(struct usbip_usb_device *udev) > { > Looks good to me. Acked-by: Shuah Khan thanks, -- Shuah