From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v6,02/13] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 From: Yu Chen Message-Id: Date: Tue, 30 Apr 2019 14:07:55 +0800 To: Rob Herring Cc: liuyu712@hisilicon.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, john.stultz@linaro.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, wanghu17@hisilicon.com, butao@hisilicon.com, chenyao11@huawei.com, fangshengzhou@hisilicon.com, lipengcheng8@huawei.com, songxiaowei@hisilicon.com, xuyiping@hisilicon.com, xuyoujun4@huawei.com, yudongbin@hisilicon.com, zangleigang@hisilicon.com, Kishon Vijay Abraham I , Sergei Shtylyov , Mark Rutland , Binghui Wang List-ID: SGkgUm9iLAoKT24gMjAxOS80LzI2IDU6MzUsIFJvYiBIZXJyaW5nIHdyb3RlOgo+IE9uIFNhdCwg QXByIDIwLCAyMDE5IGF0IDAyOjQwOjA4UE0gKzA4MDAsIFl1IENoZW4gd3JvdGU6Cj4+IFRoaXMg cGF0Y2ggYWRkcyBiaW5kaW5nIGRvY3VtZW50YXRpb24gdG8gc3VwcG9ydCB1c2IgaHViIGFuZCB1 c2IKPj4gZGF0YSByb2xlIHN3aXRjaCBvZiBIaXNpbGljb24gSGlLZXk5NjAgQm9hcmQuCj4gCj4g U29ycnkgSSd2ZSBiZWVuIHNsb3cgdG8gcmVhbGx5IHJldmlldyB0aGlzLCBidXQgSSBuZWVkZWQg dG8gbG9vayBhdCB0aGUgCj4gc2NoZW1hdGljcyB0byBzZWUgd2hhdCBleGFjdGx5IGlzIGdvaW5n IG9uIGhlcmUuCj4gCj4gSSB0aGluayB0aGlzIG5lZWRzIHNvbWUgY2hhbmdlcyB0byBiZXR0ZXIg cmVmbGVjdCB0aGUgaC93IGFuZCB1dGlsaXplIAo+IGV4aXN0aW5nIGJpbmRpbmdzLiBJdCBzaG91 bGQgcmVhbGx5IGJlIGRlc2lnbmVkIGlnbm9yaW5nIHRoZSBtdXhpbmcgdG8gCj4gc3RhcnQgd2l0 aC4gRGVmaW5lIHRoZSBiaW5kaW5nIGZvciB0aGUgVHlwZUMgY29ubmVjdG9yIGFuZCB0aGVuIHRo ZSBob3N0IAo+IGh1YiBhbmQgbWFrZSBzdXJlIHRoZXkgY2FuIGNvZXhpc3QuIFRoZW4gb3Zlcmxh eSB3aGF0IHlvdSBuZWVkIHRvIHN3aXRjaCAKPiBiZXR3ZWVuIHRoZSAyIG1vZGVzIHdoaWNoIEFG QUlDVCBpcyBqdXN0IGEgc2luZ2xlIEdQSU8uIAo+IAo+Pgo+PiBDYzogS2lzaG9uIFZpamF5IEFi cmFoYW0gSSA8a2lzaG9uQHRpLmNvbT4KPj4gQ2M6IFNlcmdlaSBTaHR5bHlvdiA8c2VyZ2VpLnNo dHlseW92QGNvZ2VudGVtYmVkZGVkLmNvbT4KPj4gQ2M6IFJvYiBIZXJyaW5nIDxyb2JoK2R0QGtl cm5lbC5vcmc+Cj4+IENjOiBNYXJrIFJ1dGxhbmQgPG1hcmsucnV0bGFuZEBhcm0uY29tPgo+PiBD YzogSm9obiBTdHVsdHogPGpvaG4uc3R1bHR6QGxpbmFyby5vcmc+Cj4+IENjOiBCaW5naHVpIFdh bmcgPHdhbmdiaW5naHVpQGhpc2lsaWNvbi5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IFl1IENoZW4g PGNoZW55dTU2QGh1YXdlaS5jb20+Cj4+IC0tLQo+PiB2MToKPj4gKiBGaXggc29tZSBmb3JtYXQg ZXJyb3JzIGFzIHN1Z2dlc3RlZCBieSBTZXJnZWkuCj4+ICogTW9kaWZ5IGdwaW8gZGVzY3JpcHRp b24gdG8gdXNlIGdwaW9kIEFQSS4KPj4gdjI6Cj4+ICogUmVtb3ZlIGluZm9ybWF0aW9uIGFib3V0 IEhpa2V5Lgo+PiAqIEZpeCBncGlvIGRlc2NyaXB0aW9uLgo+PiAqIFJlbW92ZSBkZXZpY2VfdHlw ZSBvZiBlbmRwb2ludC4KPj4gdjM6Cj4+ICogUmVtb3ZlIHByb3BlcnR5IHR5cGVjLXZidXMtZW5h YmxlLXZhbC4KPj4gKiBBZGQgZGVzY3JpcHRpb24gb2YgcGluY3RybC1uYW1lcy4KPj4gKiBBZGQg ZXhhbXBsZSBmb3IgImhpc2lsaWNvbixncGlvLWh1YnYxIgo+PiAqIEFkZCBmbGFnIGluIGdwaW9k IHByb3BlcnRpZXMuCj4+IC0tLQo+PiAtLS0KPj4gIC4uLi9iaW5kaW5ncy9taXNjL2hpc2lsaWNv bi1oaWtleS11c2IudHh0ICAgICAgICAgIHwgNTIgKysrKysrKysrKysrKysrKysrKysrKwo+PiAg MSBmaWxlIGNoYW5nZWQsIDUyIGluc2VydGlvbnMoKykKPj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBE b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWlzYy9oaXNpbGljb24taGlrZXktdXNi LnR4dAo+Pgo+PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L21pc2MvaGlzaWxpY29uLWhpa2V5LXVzYi50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvbWlzYy9oaXNpbGljb24taGlrZXktdXNiLnR4dAo+PiBuZXcgZmlsZSBtb2RlIDEw MDY0NAo+PiBpbmRleCAwMDAwMDAwMDAwMDAuLjQyMmU4NDRkZjcxOQo+PiAtLS0gL2Rldi9udWxs Cj4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9taXNjL2hpc2lsaWNv bi1oaWtleS11c2IudHh0Cj4+IEBAIC0wLDAgKzEsNTIgQEAKPj4gK1N1cHBvcnQgdXNiIGh1YiBh bmQgdXNiIGRhdGEgcm9sZSBzd2l0Y2ggb2YgSGlzaWxpY29uIEhpS2V5OTYwIEJvYXJkLgo+PiAr Cj4+ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+PiArCj4+ICtSZXF1aXJlZCBwcm9w ZXJ0aWVzOgo+PiArLSBjb21wYXRpYmxlOiAiaGlzaWxpY29uLGdwaW8taHVidjEiLCJoaXNpbGlj b24saGlrZXk5NjAtdXNiIgo+PiArLSB0eXBlYy12YnVzLWdwaW9zOiBncGlvIHRvIGNvbnRyb2wg dGhlIHZidXMgb2YgdHlwZUMgcG9ydAo+IAo+IFRoaXMgc2hvdWxkIGJlIGEgZ3BpbyByZWd1bGF0 b3IgYW5kIHRoZW4gY29ubmVjdGVkIHRvICd2YnVzLXN1cHBseScgaW4gYSAKPiB1c2ItY29ubmVj dG9yIG5vZGUgKHNlZSAuLi4vYmluZGluZ3MvY29ubmVjdG9ycy91c2ItY29ubmVjdG9yLnR4dCku IApDdXJyZW50bHkgdXNiLWNvbm5lY3RvciBub2RlIGhhcyBubyAidmJ1cy1zdXBwbHkiIHByb3Bl cnR5IGFuZApJIGRvIG5vdCBmaW5kIHByb2Nlc3MgdGhhdCBoYW5kbGVzIHZidXMtc3VwcGx5IGlu IFJUMTcxMUggVHlwZUMgZHJpdmVyLgoKPiAKPiBUaGVuIHlvdSBhbHNvIG5lZWQgdGhlIFJUMTcx MUhXU0MgVHlwZUMgY29udHJvbGxlciBpbiBEVC4gVGhhdCBpcyAKPiB0eXBpY2FsbHkgdGhlIHBh cmVudCBkZXZpY2Ugb2YgdGhlIGNvbm5lY3RvciBub2RlLiAKPiAKPj4gKy0gb3RnLXN3aXRjaC1n cGlvczogZ3BpbyB0byBzd2l0Y2ggRFAgJiBETSBiZXR3ZWVuIHRoZSBodWIgYW5kIHR5cGVDIHBv cnQKPiAKPiBUaGlzIHByb2JhYmx5IGJlbG9uZ3MgaW4gVVNCIGNvbnRyb2xsZXIgbm9kZS4KPiAK VGhlIG90Zy1zd2l0Y2gtZ3Bpb3MgY29udHJvbHMgYSBtdXggbGlrZSBmc3VzYjMwbXV4LiBJdCBp cyByZWxhdGVkIHRvCnRoZSBib2FyZCBkZXNpZ24gb2YgSGlLZXk5NjAuIEFuZCB0aGUgc3RhdGUg b2YgdGhlIG11eCBpcyBkZWNpZGVkIGJ5CnRoZSB0eXBlQyBwb3J0IHN0YXRlLiBTbyBJIHRoaW5r IGl0IGlzIG5vdCBzbyBnb29kIHRvIG1ha2UgaXQgYmVsb25ncwppbiBVU0IgY29udHJvbGxlciBu b2RlLgoKPj4gKy0gaHViLXZkZDMzLWVuLWdwaW9zOiBncGlvIHRvIGVuYWJsZSB0aGUgcG93ZXIg b2YgaHViCj4gCj4gVGhpcyB0b28gc2hvdWxkIGJlIGEgZ3BpbyByZWd1bGF0b3IgYW5kIHRoZW4g aW4gYSBodWIgbm9kZS4gV2UgaGF2ZSAyIAo+IHdheXMgdG8gcmVwcmVzZW50IGh1YnMuIEVpdGhl ciBhcyBhbiBJMkMgZGV2aWNlIG9yIGFzIGEgY2hpbGQgb2YgdGhlIAo+IGhvc3QgY29udHJvbGxl ci4gVGhlIGxhdHRlciBpcyBwcmVmZXJyZWQsIGJ1dCBJJ20gbm90IHRvbyBzdXJlIGhvdyB0aGUg Cj4gT0YgZ3JhcGggY29ubmVjdGlvbiBsaW5raW5nIHRoZSBjb250cm9sbGVyIHRvIHRoZSBUeXBl QyBjb25uZWN0b3Igd2lsbCAKPiB3b3JrIHdpdGggdGhlIHVzYiBidXMgYmluZGluZy4KPiAKVGhl cmUgaXMgbm8gcGFydGljdWxhciBjb2RlIGV4Y2VwdCB0aGUgcG93ZXIgY29udHJvbCBmb3IgdGhl IGh1Yi4KVGhlIGkyYyBvbiB0aGUgaHViIGlzIG5vdCB1c2VkLiBTbyBpdCBjYW4gbm90IGJlIGFu IEkyQyBkZXZpY2UuCklzIHRoZXJlIHN1Y2ggYW4gZXhhbXBsZSB0aGF0IG1ha2UgdGhlIGh1YiBh cyBhIGNoaWxkIG9mIHRoZSBob3N0IGNvbnRyb2xsZXIKYW5kIGNvbnRyb2wgaXRzIHBvd2VyPwoK Pj4gKy0gcGluY3RybC1uYW1lczogcGluIGNvbmZpZ3VyYXRpb24gc3RhdGUgbmFtZSAoImRlZmF1 bHQiKQo+PiArLSBwaW5jdHJsLTA6IHBpbmN0cmwgY29uZmlnCj4+ICsKPj4gK0V4YW1wbGUKPj4g Ky0tLS0tCj4+ICsKPj4gKwloaXNpX2hpa2V5X3VzYjogaGlzaV9oaWtleV91c2Igewo+PiArCQlj b21wYXRpYmxlID0gImhpc2lsaWNvbixoaWtleTk2MC11c2IiOwo+PiArCQl0eXBlYy12YnVzLWdw aW9zID0gPCZncGlvMjUgMiBHUElPX0FDVElWRV9ISUdIPjsKPj4gKwkJb3RnLXN3aXRjaC1ncGlv cyA9IDwmZ3BpbzI1IDYgR1BJT19BQ1RJVkVfSElHSD47Cj4+ICsJCWh1Yi12ZGQzMy1lbi1ncGlv cyA9IDwmZ3BpbzUgNiBHUElPX0FDVElWRV9ISUdIPjsKPj4gKwkJcGluY3RybC1uYW1lcyA9ICJk ZWZhdWx0IjsKPj4gKwkJcGluY3RybC0wID0gPCZ1c2JodWI1NzM0X3BteF9mdW5jPjsKPj4gKwo+ PiArCQlwb3J0IHsKPj4gKwkJCSNhZGRyZXNzLWNlbGxzID0gPDE+Owo+PiArCQkJI3NpemUtY2Vs bHMgPSA8MD47Cj4+ICsKPj4gKwkJCWhpa2V5X3VzYl9lcDogZW5kcG9pbnRAMCB7Cj4+ICsJCQkJ cmVnID0gPDA+Owo+PiArCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmZHdjM19yb2xlX3N3aXRjaF9u b3RpZnk+Owo+PiArCQkJfTsKPj4gKwkJfTsKPj4gKwl9Owo+PiArCj4+ICsJaGlzaV9oaWtleV91 c2I6IGhpc2lfaGlrZXlfdXNiIHsKPiAKPiBQZXJoYXBzIGRvZXNuJ3QgbWF0dGVyIHdpdGggbXkg YWJvdmUgZmVlZGJhY2ssIGJ1dCBJIGRvbid0IHVuZGVyc3RhbmQgCj4gdGhlIHBvaW50IG9mIHRo aXMgMm5kIGV4YW1wbGUuCj4gCk9LLiBJIHdpbGwgcmVtb3ZlIGl0Lgo+PiArCQljb21wYXRpYmxl ID0gImhpc2lsaWNvbixncGlvLWh1YnYxIjsKPj4gKwkJdHlwZWMtdmJ1cy1ncGlvcyA9IDwmZ3Bp bzI1IDIgR1BJT19BQ1RJVkVfTE9XPjsKPj4gKwkJb3RnLXN3aXRjaC1ncGlvcyA9IDwmZ3BpbzI1 IDYgR1BJT19BQ1RJVkVfSElHSD47Cj4+ICsJCWh1Yi12ZGQzMy1lbi1ncGlvcyA9IDwmZ3BpbzUg NiBHUElPX0FDVElWRV9ISUdIPjsKPj4gKwkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPj4g KwkJcGluY3RybC0wID0gPCZ1c2JodWI1NzM0X3BteF9mdW5jPjsKPj4gKwo+PiArCQlwb3J0IHsK Pj4gKwkJCSNhZGRyZXNzLWNlbGxzID0gPDE+Owo+PiArCQkJI3NpemUtY2VsbHMgPSA8MD47Cj4+ ICsKPj4gKwkJCWhpa2V5X3VzYl9lcDogZW5kcG9pbnRAMCB7Cj4+ICsJCQkJcmVnID0gPDA+Owo+ PiArCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmZHdjM19yb2xlX3N3aXRjaF9ub3RpZnk+Owo+PiAr CQkJfTsKPj4gKwkJfTsKPj4gKwl9Owo+PiAtLSAKPj4gMi4xNS4wLXJjMgo+Pgo+IAo+IC4KPiAK ClRoYW5rcwotIFl1IENoZW4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48B62C43219 for ; Tue, 30 Apr 2019 06:08:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21D152075E for ; Tue, 30 Apr 2019 06:08:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726012AbfD3GIJ (ORCPT ); Tue, 30 Apr 2019 02:08:09 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:58102 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725554AbfD3GIJ (ORCPT ); Tue, 30 Apr 2019 02:08:09 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 0394B9A3133819C6DFC7; Tue, 30 Apr 2019 14:08:06 +0800 (CST) Received: from [127.0.0.1] (10.142.63.192) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.439.0; Tue, 30 Apr 2019 14:07:57 +0800 CC: , , , , , , , , , , , , , , , , , Kishon Vijay Abraham I , "Sergei Shtylyov" , Mark Rutland , Binghui Wang Subject: Re: [PATCH v6 02/13] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 To: Rob Herring References: <20190420064019.57522-1-chenyu56@huawei.com> <20190420064019.57522-3-chenyu56@huawei.com> <20190425213532.GA32028@bogus> From: Chen Yu Message-ID: Date: Tue, 30 Apr 2019 14:07:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20190425213532.GA32028@bogus> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.63.192] X-CFilter-Loop: Reflected Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190430060755.3V9cah2I5_gd2vFvCQuv_Cw4IUSuSTNil6LOqkEUPp4@z> Hi Rob, On 2019/4/26 5:35, Rob Herring wrote: > On Sat, Apr 20, 2019 at 02:40:08PM +0800, Yu Chen wrote: >> This patch adds binding documentation to support usb hub and usb >> data role switch of Hisilicon HiKey960 Board. > > Sorry I've been slow to really review this, but I needed to look at the > schematics to see what exactly is going on here. > > I think this needs some changes to better reflect the h/w and utilize > existing bindings. It should really be designed ignoring the muxing to > start with. Define the binding for the TypeC connector and then the host > hub and make sure they can coexist. Then overlay what you need to switch > between the 2 modes which AFAICT is just a single GPIO. > >> >> Cc: Kishon Vijay Abraham I >> Cc: Sergei Shtylyov >> Cc: Rob Herring >> Cc: Mark Rutland >> Cc: John Stultz >> Cc: Binghui Wang >> Signed-off-by: Yu Chen >> --- >> v1: >> * Fix some format errors as suggested by Sergei. >> * Modify gpio description to use gpiod API. >> v2: >> * Remove information about Hikey. >> * Fix gpio description. >> * Remove device_type of endpoint. >> v3: >> * Remove property typec-vbus-enable-val. >> * Add description of pinctrl-names. >> * Add example for "hisilicon,gpio-hubv1" >> * Add flag in gpiod properties. >> --- >> --- >> .../bindings/misc/hisilicon-hikey-usb.txt | 52 ++++++++++++++++++++++ >> 1 file changed, 52 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/misc/hisilicon-hikey-usb.txt >> >> diff --git a/Documentation/devicetree/bindings/misc/hisilicon-hikey-usb.txt b/Documentation/devicetree/bindings/misc/hisilicon-hikey-usb.txt >> new file mode 100644 >> index 000000000000..422e844df719 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/misc/hisilicon-hikey-usb.txt >> @@ -0,0 +1,52 @@ >> +Support usb hub and usb data role switch of Hisilicon HiKey960 Board. >> + >> +----------------------------- >> + >> +Required properties: >> +- compatible: "hisilicon,gpio-hubv1","hisilicon,hikey960-usb" >> +- typec-vbus-gpios: gpio to control the vbus of typeC port > > This should be a gpio regulator and then connected to 'vbus-supply' in a > usb-connector node (see .../bindings/connectors/usb-connector.txt). Currently usb-connector node has no "vbus-supply" property and I do not find process that handles vbus-supply in RT1711H TypeC driver. > > Then you also need the RT1711HWSC TypeC controller in DT. That is > typically the parent device of the connector node. > >> +- otg-switch-gpios: gpio to switch DP & DM between the hub and typeC port > > This probably belongs in USB controller node. > The otg-switch-gpios controls a mux like fsusb30mux. It is related to the board design of HiKey960. And the state of the mux is decided by the typeC port state. So I think it is not so good to make it belongs in USB controller node. >> +- hub-vdd33-en-gpios: gpio to enable the power of hub > > This too should be a gpio regulator and then in a hub node. We have 2 > ways to represent hubs. Either as an I2C device or as a child of the > host controller. The latter is preferred, but I'm not too sure how the > OF graph connection linking the controller to the TypeC connector will > work with the usb bus binding. > There is no particular code except the power control for the hub. The i2c on the hub is not used. So it can not be an I2C device. Is there such an example that make the hub as a child of the host controller and control its power? >> +- pinctrl-names: pin configuration state name ("default") >> +- pinctrl-0: pinctrl config >> + >> +Example >> +----- >> + >> + hisi_hikey_usb: hisi_hikey_usb { >> + compatible = "hisilicon,hikey960-usb"; >> + typec-vbus-gpios = <&gpio25 2 GPIO_ACTIVE_HIGH>; >> + otg-switch-gpios = <&gpio25 6 GPIO_ACTIVE_HIGH>; >> + hub-vdd33-en-gpios = <&gpio5 6 GPIO_ACTIVE_HIGH>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&usbhub5734_pmx_func>; >> + >> + port { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + hikey_usb_ep: endpoint@0 { >> + reg = <0>; >> + remote-endpoint = <&dwc3_role_switch_notify>; >> + }; >> + }; >> + }; >> + >> + hisi_hikey_usb: hisi_hikey_usb { > > Perhaps doesn't matter with my above feedback, but I don't understand > the point of this 2nd example. > OK. I will remove it. >> + compatible = "hisilicon,gpio-hubv1"; >> + typec-vbus-gpios = <&gpio25 2 GPIO_ACTIVE_LOW>; >> + otg-switch-gpios = <&gpio25 6 GPIO_ACTIVE_HIGH>; >> + hub-vdd33-en-gpios = <&gpio5 6 GPIO_ACTIVE_HIGH>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&usbhub5734_pmx_func>; >> + >> + port { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + hikey_usb_ep: endpoint@0 { >> + reg = <0>; >> + remote-endpoint = <&dwc3_role_switch_notify>; >> + }; >> + }; >> + }; >> -- >> 2.15.0-rc2 >> > > . > Thanks - Yu Chen