RE: [PATCH v1] usb: xhci: plat: Add USB 3.0 phy support

["Stanley Chang[昌育德]" <stanley_chang@realtek.com>]

Hi Klaus,

> > diff --git a/drivers/usb/host/xhci-plat.c
> > b/drivers/usb/host/xhci-plat.c index b9f9625467d6..61c95349b998 100644
> > --- a/drivers/usb/host/xhci-plat.c
> > +++ b/drivers/usb/host/xhci-plat.c
> > @@ -291,6 +291,21 @@ int xhci_plat_probe(struct platform_device *pdev,
> struct device *sysdev, const s
> >                         goto dealloc_usb2_hcd;
> >                 }
> >
> > +               xhci->shared_hcd->usb_phy =
> devm_usb_get_phy_by_phandle(sysdev,
> > +                           "usb-phy", 1);
> > +               if (IS_ERR(xhci->shared_hcd->usb_phy)) {
> > +                       if (PTR_ERR(xhci->shared_hcd->usb_phy) !=
> -ENODEV)
> > +                               dev_err(sysdev, "%s get usb3phy fail
> > + (ret=%d)\n",
> 
> Hello,
> 
> I'm booting 6.4-rc1 on a Turris Omnia
> (arm/boot/dts/armada-385-turris-omnia.dts)
> and get those error messages:
> [    0.231609] xhci-hcd f10f0000.usb3: xhci_plat_probe get usb3phy fail
> (ret=-6)
> [    0.239716] xhci-hcd f10f8000.usb3: xhci_plat_probe get usb3phy fail
> (ret=-6)
> 
> It looks like a cosmetic issue with error codes, but maybe it can be fixed?
> 

1. I checked arm/boot/dts/armada-385-turris-omnia.dts.
The xhci node doesn't seem to have usb-phy.
In this case it should get error code -ENODEV (-19).
I'm not sure why the error code is -ENXIO (-6).
Can you provide more details?

2. This error message will be printed only when getting the usb3 phy fails.
And usb_phy set to NULL, It does not affect the original behavior.
Maybe I'm missing checking -ENXIO or some other error code.
I can delete this log according to usb2 phy situation.

Thanks,
Stanley