From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org,
mario.limonciello@amd.com,
Oleksandr Natalenko <oleksandr@natalenko.name>
Subject: Re: [PATCH v3] xhci: Allow RPM on the USB controller (1022:43f7) by default
Date: Tue, 5 Mar 2024 15:08:58 +0200 [thread overview]
Message-ID: <f9f89ec1-6baf-4a61-e685-a0f311b5a298@linux.intel.com> (raw)
In-Reply-To: <2024030555-fervor-unlovely-98c5@gregkh>
On 5.3.2024 14.04, Greg KH wrote:
> On Mon, Mar 04, 2024 at 11:13:27AM +0530, Basavaraj Natikar wrote:
>> Enable runtime PM by default for older AMD 1022:43f7 xHCI 1.1 host as it
>> is proven to work.
>> Driver enables runtime PM by default for newer xHCI 1.2 host.
>>
>> Link: https://lore.kernel.org/all/12335218.O9o76ZdvQC@natalenko.name/
>> Cc: Mario Limonciello <mario.limonciello@amd.com>
>> Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
>> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
>> ---
>> Changes in v3:
>> - Reworded the commit message.
>> - Removed fixes and stable tags.
>
> Why? Why doesn't this belong in a stable kernel? It's a quirk fix,
> don't you want this on systems that are running 6.1 and 6.6? Or are you
> willing to wait for 6.9?
Might be better to add it to stable after it has been upstream for some time.
Previous attempt to enable default runtime PM for AMD xHCI 1.1 hosts caused
regressions and had to be reverted from everywhere:
https://lore.kernel.org/r/20231205090548.1377667-1-mathias.nyman@linux.intel.com
Thanks
Mathias
next prev parent reply other threads:[~2024-03-05 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 5:43 [PATCH v3] xhci: Allow RPM on the USB controller (1022:43f7) by default Basavaraj Natikar
2024-03-05 12:04 ` Greg KH
2024-03-05 13:08 ` Mathias Nyman [this message]
2024-03-05 13:43 ` Greg KH
2024-03-05 13:51 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9f89ec1-6baf-4a61-e685-a0f311b5a298@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mathias.nyman@intel.com \
--cc=oleksandr@natalenko.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox