From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 039E0C433F5 for ; Tue, 19 Oct 2021 18:28:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D46D361260 for ; Tue, 19 Oct 2021 18:28:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232170AbhJSSaY (ORCPT ); Tue, 19 Oct 2021 14:30:24 -0400 Received: from mxout04.lancloud.ru ([45.84.86.114]:56840 "EHLO mxout04.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231783AbhJSSaX (ORCPT ); Tue, 19 Oct 2021 14:30:23 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru 744E320ACBAF Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 00/22] Explicitly deny IRQ0 in the USB host drivers To: Greg Kroah-Hartman CC: , Alan Stern , Mathias Nyman References: <20211018183930.8448-1-s.shtylyov@omp.ru> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Tue, 19 Oct 2021 21:28:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 10/19/21 10:31 AM, Greg Kroah-Hartman wrote: [...] >>> Here are 22 patches against the 'usb-next' branch of Greg KH's 'usb.git' repo. >>> The affected drivers use platform_get_irq() which can return IRQ0 (considered >>> invalid, according to Linus) that means broken HCD when passed to usb_add_hcd() >>> called at the end of the probe methods. I think that the solution to this issue >>> is either explicitly deny or accept IRQ0 in usb_add_hcd()... /but/ here's this >>> patch set to get the things going... >> >> Why not fix the root of the problem for your platform that is failing to >> assign a valid irq for the device? >> >> Are you going to make this change to all callers of this function in the >> kernel tree? > > Also, you should have gotten a huge WARNING in your kernel log if this > happens to let you know that something bad is going on. That's the relatively recent addition, yet it doesn't override IRQ0 to s/th like -EINVAL. > Is this patch > series going to really change any of that? How? It doesn't touch drivers/base/platform.c... > > What is the root problem here that you are trying to paper over with > this patchset? As I said, it would be preferrable to either deny IRQ0 in usb_add_hcd() or just don't try to filter it out. The real problem is that usb_add_hcd() does add a non-functioning HCD without the necessary IRQ handling (it only hooks an IRQ when it's non-zero). > thanks, > > greg k-h MBR, Sergey