From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D34EC4363A for ; Thu, 22 Oct 2020 06:48:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B946222E9 for ; Thu, 22 Oct 2020 06:48:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="LmdgwX8S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440698AbgJVGsU (ORCPT ); Thu, 22 Oct 2020 02:48:20 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:39782 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439712AbgJVGsU (ORCPT ); Thu, 22 Oct 2020 02:48:20 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 09M6mCZc096285; Thu, 22 Oct 2020 01:48:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1603349292; bh=ImUa0bBNCXwKjWXUfmUPNeV+bh24MQT7Z8B6vfNQNLU=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=LmdgwX8SQ6zgV6RziQtNMYRojXvfn0930ergmZ60aBB2xBcsc4KRndenRBVqU7h5M wH6wtZHWot4UEDD2XaCd2MiwNYVYMxxCZqcxISqVtqk0t/6hQcR1D3SqYWzlv43nmE WQGeGKXmEBdHRyHZKRNZTOh/UknoMfMf6sBxSFLY= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 09M6mCcU027356 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 22 Oct 2020 01:48:12 -0500 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 22 Oct 2020 01:48:12 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 22 Oct 2020 01:48:12 -0500 Received: from [192.168.2.14] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 09M6m9e0056016; Thu, 22 Oct 2020 01:48:10 -0500 Subject: Re: [PATCH 1/2] usb: host: add XHCI_CDNS_HOST flag To: Peter Chen , CC: , , , , Pawel Laszczak References: <20201022030133.19528-1-peter.chen@nxp.com> From: Roger Quadros Message-ID: Date: Thu, 22 Oct 2020 09:48:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201022030133.19528-1-peter.chen@nxp.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Peter, On 22/10/2020 06:01, Peter Chen wrote: > The Cadence xHCI host has the same issue with Intel's, s/with/as > it is triggered by reboot stress test. Can you please provide some more details about the test so I can try at my end. Thanks. cheers, -roger > > Cc: Pawel Laszczak > Cc: Roger Quadros > Signed-off-by: Peter Chen > --- > drivers/usb/host/xhci.c | 2 +- > drivers/usb/host/xhci.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c > index 482fe8c5e3b4..fc72a03dc27f 100644 > --- a/drivers/usb/host/xhci.c > +++ b/drivers/usb/host/xhci.c > @@ -193,7 +193,7 @@ int xhci_reset(struct xhci_hcd *xhci) > * Without this delay, the subsequent HC register access, > * may result in a system hang very rarely. > */ > - if (xhci->quirks & XHCI_INTEL_HOST) > + if (xhci->quirks & (XHCI_INTEL_HOST | XHCI_CDNS_HOST)) > udelay(1000); > > ret = xhci_handshake(&xhci->op_regs->command, > diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h > index 8be88379c0fb..4b7275c73ea5 100644 > --- a/drivers/usb/host/xhci.h > +++ b/drivers/usb/host/xhci.h > @@ -1877,6 +1877,7 @@ struct xhci_hcd { > #define XHCI_SNPS_BROKEN_SUSPEND BIT_ULL(35) > #define XHCI_RENESAS_FW_QUIRK BIT_ULL(36) > #define XHCI_SKIP_PHY_INIT BIT_ULL(37) > +#define XHCI_CDNS_HOST BIT_ULL(38) > > unsigned int num_active_eps; > unsigned int limit_active_eps; > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki