From: Hans de Goede <hansg@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Israel Cepeda <israel.a.cepeda.lopez@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Wolfram Sang <wsa@kernel.org>, Andi Shyti <andi.shyti@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
Richard Hughes <rhughes@redhat.com>,
linux-i2c@vger.kernel.org, linux-usb@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v4 3/3] i2c: Add Intel USBIO I2C driver
Date: Thu, 11 Sep 2025 20:12:51 +0200 [thread overview]
Message-ID: <fcf2f155-9215-4a73-98b7-de8f58fe851a@kernel.org> (raw)
In-Reply-To: <aMLf9Nj3hF4t9rQH@ninjato>
Hi,
On 11-Sep-25 4:43 PM, Wolfram Sang wrote:
>
>>> How did you test 10 bit addresses? I have never seen them in the wild?
>>
>> I did not test 10 bit addresses. This was there in the original code
>> from Intel.
>
> I suggest to drop it. There is no code handling the I2C_M_TEN flag which
> should be handled if support is advertised.
Ok, I'll drop this for v6. Hopefully that will be the last
version of this series then.
Regards,
Hans
prev parent reply other threads:[~2025-09-11 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 13:39 [PATCH v4 0/3] usb/gpio/i2c: Add Intel USBIO USB IO-expander drivers Hans de Goede
2025-09-10 13:39 ` [PATCH v4 1/3] usb: misc: Add Intel USBIO bridge driver Hans de Goede
2025-09-10 13:39 ` [PATCH v4 2/3] gpio: Add Intel USBIO GPIO driver Hans de Goede
2025-09-10 21:41 ` Linus Walleij
2025-09-11 10:44 ` Hans de Goede
2025-09-10 13:39 ` [PATCH v4 3/3] i2c: Add Intel USBIO I2C driver Hans de Goede
2025-09-10 21:54 ` Wolfram Sang
2025-09-11 11:48 ` Hans de Goede
2025-09-11 14:43 ` Wolfram Sang
2025-09-11 18:12 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcf2f155-9215-4a73-98b7-de8f58fe851a@kernel.org \
--to=hansg@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=brgl@bgdev.pl \
--cc=gregkh@linuxfoundation.org \
--cc=israel.a.cepeda.lopez@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rhughes@redhat.com \
--cc=sakari.ailus@linux.intel.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox