* [PATCH] usb: dwc2: gadget: Use USB API functions rather than constants
@ 2025-05-19 6:22 Chen Ni
2025-06-03 7:18 ` Minas Harutyunyan
0 siblings, 1 reply; 2+ messages in thread
From: Chen Ni @ 2025-05-19 6:22 UTC (permalink / raw)
To: hminas, gregkh; +Cc: linux-usb, linux-kernel, Chen Ni
Use the function usb_endpoint_type() rather than constants.
The Coccinelle semantic patch is as follows:
@@ struct usb_endpoint_descriptor *epd; @@
- (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\))
+ usb_endpoint_type(epd)
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/usb/dwc2/gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index f323fb5597b3..d5b622f78cf3 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -4049,7 +4049,7 @@ static int dwc2_hsotg_ep_enable(struct usb_ep *ep,
return -EINVAL;
}
- ep_type = desc->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK;
+ ep_type = usb_endpoint_type(desc);
mps = usb_endpoint_maxp(desc);
mc = usb_endpoint_maxp_mult(desc);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: dwc2: gadget: Use USB API functions rather than constants
2025-05-19 6:22 [PATCH] usb: dwc2: gadget: Use USB API functions rather than constants Chen Ni
@ 2025-06-03 7:18 ` Minas Harutyunyan
0 siblings, 0 replies; 2+ messages in thread
From: Minas Harutyunyan @ 2025-06-03 7:18 UTC (permalink / raw)
To: Chen Ni, Minas Harutyunyan, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
On 5/19/25 10:22, Chen Ni wrote:
> Use the function usb_endpoint_type() rather than constants.
> The Coccinelle semantic patch is as follows:
>
> @@ struct usb_endpoint_descriptor *epd; @@
>
> - (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\))
> + usb_endpoint_type(epd)
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
> ---
> drivers/usb/dwc2/gadget.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index f323fb5597b3..d5b622f78cf3 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -4049,7 +4049,7 @@ static int dwc2_hsotg_ep_enable(struct usb_ep *ep,
> return -EINVAL;
> }
>
> - ep_type = desc->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK;
> + ep_type = usb_endpoint_type(desc);
> mps = usb_endpoint_maxp(desc);
> mc = usb_endpoint_maxp_mult(desc);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-03 7:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-19 6:22 [PATCH] usb: dwc2: gadget: Use USB API functions rather than constants Chen Ni
2025-06-03 7:18 ` Minas Harutyunyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).