* Re: [PATCH] dt-bindings: usb: mtu3: Add ports property
2025-02-20 14:22 [PATCH] dt-bindings: usb: mtu3: Add ports property Macpaul Lin
@ 2025-02-20 15:56 ` AngeloGioacchino Del Regno
2025-02-21 17:46 ` Conor Dooley
2025-02-22 8:35 ` Chunfeng Yun (云春峰)
2025-02-25 9:02 ` AngeloGioacchino Del Regno
2 siblings, 1 reply; 7+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-02-20 15:56 UTC (permalink / raw)
To: Macpaul Lin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Chunfeng Yun, Greg Kroah-Hartman, linux-usb,
Alexandre Mergnat
Cc: Bear Wang, Pablo Sun, Macpaul Lin,
Project_Global_Chrome_Upstream_Group, Chris-qj chen
Il 20/02/25 15:22, Macpaul Lin ha scritto:
> Define the ports property in the mediatek,mtu3 device tree binding schema.
> Include definitions for port@0 and port@1, specifying their roles as
> High Speed (HS) and Super Speed (SS) data buses, respectively.
>
> Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
Some SoCs do have SuperSpeed peripheral mode, so for this commit
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../devicetree/bindings/usb/mediatek,mtu3.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> index d4e187c78a0b..21fc6bbe954f 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> @@ -155,6 +155,18 @@ properties:
> property is used. See graph.txt
> $ref: /schemas/graph.yaml#/properties/port
>
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: High Speed (HS) data bus.
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Super Speed (SS) data bus.
> +
> enable-manual-drd:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: usb: mtu3: Add ports property
2025-02-20 15:56 ` AngeloGioacchino Del Regno
@ 2025-02-21 17:46 ` Conor Dooley
0 siblings, 0 replies; 7+ messages in thread
From: Conor Dooley @ 2025-02-21 17:46 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: Macpaul Lin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Chunfeng Yun, Greg Kroah-Hartman, linux-usb,
Alexandre Mergnat, Bear Wang, Pablo Sun, Macpaul Lin,
Project_Global_Chrome_Upstream_Group, Chris-qj chen
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
On Thu, Feb 20, 2025 at 04:56:00PM +0100, AngeloGioacchino Del Regno wrote:
> Il 20/02/25 15:22, Macpaul Lin ha scritto:
> > Define the ports property in the mediatek,mtu3 device tree binding schema.
> > Include definitions for port@0 and port@1, specifying their roles as
> > High Speed (HS) and Super Speed (SS) data buses, respectively.
> >
> > Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>
> Some SoCs do have SuperSpeed peripheral mode, so for this commit
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: usb: mtu3: Add ports property
2025-02-20 14:22 [PATCH] dt-bindings: usb: mtu3: Add ports property Macpaul Lin
2025-02-20 15:56 ` AngeloGioacchino Del Regno
@ 2025-02-22 8:35 ` Chunfeng Yun (云春峰)
2025-02-24 12:18 ` AngeloGioacchino Del Regno
2025-02-25 9:02 ` AngeloGioacchino Del Regno
2 siblings, 1 reply; 7+ messages in thread
From: Chunfeng Yun (云春峰) @ 2025-02-22 8:35 UTC (permalink / raw)
To: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
Macpaul Lin (林智斌), conor+dt@kernel.org,
robh@kernel.org, Alexandre Mergnat,
linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
matthias.bgg@gmail.com, krzk+dt@kernel.org,
AngeloGioacchino Del Regno
Cc: macpaul@gmail.com, Bear Wang (萩原惟德),
Chris-qj Chen (陳奇進),
Pablo Sun (孫毓翔),
Project_Global_Chrome_Upstream_Group
On Thu, 2025-02-20 at 22:22 +0800, Macpaul Lin wrote:
> Define the ports property in the mediatek,mtu3 device tree binding
> schema.
> Include definitions for port@0 and port@1, specifying their roles as
> High Speed (HS) and Super Speed (SS) data buses, respectively.
>
> Suggested-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
> .../devicetree/bindings/usb/mediatek,mtu3.yaml | 12
> ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> index d4e187c78a0b..21fc6bbe954f 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> @@ -155,6 +155,18 @@ properties:
> property is used. See graph.txt
> $ref: /schemas/graph.yaml#/properties/port
>
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: High Speed (HS) data bus.
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Super Speed (SS) data bus.
> +
> enable-manual-drd:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
Reviewed-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Thank you
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: usb: mtu3: Add ports property
2025-02-22 8:35 ` Chunfeng Yun (云春峰)
@ 2025-02-24 12:18 ` AngeloGioacchino Del Regno
2025-02-24 14:30 ` Alexandre Mergnat
0 siblings, 1 reply; 7+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-02-24 12:18 UTC (permalink / raw)
To: Chunfeng Yun (云春峰),
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
Macpaul Lin (林智斌), conor+dt@kernel.org,
robh@kernel.org, Alexandre Mergnat,
linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
matthias.bgg@gmail.com, krzk+dt@kernel.org
Cc: macpaul@gmail.com, Bear Wang (萩原惟德),
Chris-qj Chen (陳奇進),
Pablo Sun (孫毓翔),
Project_Global_Chrome_Upstream_Group
Il 22/02/25 09:35, Chunfeng Yun (云春峰) ha scritto:
> On Thu, 2025-02-20 at 22:22 +0800, Macpaul Lin wrote:
>> Define the ports property in the mediatek,mtu3 device tree binding
>> schema.
>> Include definitions for port@0 and port@1, specifying their roles as
>> High Speed (HS) and Super Speed (SS) data buses, respectively.
>>
>> Suggested-by: AngeloGioacchino Del Regno <
>> angelogioacchino.delregno@collabora.com>
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>> .../devicetree/bindings/usb/mediatek,mtu3.yaml | 12
>> ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> index d4e187c78a0b..21fc6bbe954f 100644
>> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> @@ -155,6 +155,18 @@ properties:
>> property is used. See graph.txt
>> $ref: /schemas/graph.yaml#/properties/port
>>
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + properties:
>> + port@0:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: High Speed (HS) data bus.
>> +
>> + port@1:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: Super Speed (SS) data bus.
>> +
>> enable-manual-drd:
>> $ref: /schemas/types.yaml#/definitions/flag
>> description:
> Reviewed-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>
> Thank you
>
Is everyone okay if I pick this (and the XHCI one [1]) in the MediaTek trees?
This is so that I don't get devicetree warnings when picking the DT patches
that are adding USB MUX/TCPC to the MediaTek boards.
[1]:
https://lore.kernel.org/r/20250220105514.43107-2-angelogioacchino.delregno@collabora.com
Thanks,
Angelo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: usb: mtu3: Add ports property
2025-02-24 12:18 ` AngeloGioacchino Del Regno
@ 2025-02-24 14:30 ` Alexandre Mergnat
0 siblings, 0 replies; 7+ messages in thread
From: Alexandre Mergnat @ 2025-02-24 14:30 UTC (permalink / raw)
To: AngeloGioacchino Del Regno,
Chunfeng Yun (云春峰),
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
Macpaul Lin (林智斌), conor+dt@kernel.org,
robh@kernel.org, linux-arm-kernel@lists.infradead.org,
gregkh@linuxfoundation.org, matthias.bgg@gmail.com,
krzk+dt@kernel.org
Cc: macpaul@gmail.com, Bear Wang (萩原惟德),
Chris-qj Chen (陳奇進),
Pablo Sun (孫毓翔),
Project_Global_Chrome_Upstream_Group
On 24/02/2025 13:18, AngeloGioacchino Del Regno wrote:
> Il 22/02/25 09:35, Chunfeng Yun (云春峰) ha scritto:
>> On Thu, 2025-02-20 at 22:22 +0800, Macpaul Lin wrote:
>>> Define the ports property in the mediatek,mtu3 device tree binding
>>> schema.
>>> Include definitions for port@0 and port@1, specifying their roles as
>>> High Speed (HS) and Super Speed (SS) data buses, respectively.
>>>
>>> Suggested-by: AngeloGioacchino Del Regno <
>>> angelogioacchino.delregno@collabora.com>
>>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>>> ---
>>> .../devicetree/bindings/usb/mediatek,mtu3.yaml | 12
>>> ++++++++++++
>>> 1 file changed, 12 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>>> b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>>> index d4e187c78a0b..21fc6bbe954f 100644
>>> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>>> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>>> @@ -155,6 +155,18 @@ properties:
>>> property is used. See graph.txt
>>> $ref: /schemas/graph.yaml#/properties/port
>>> + ports:
>>> + $ref: /schemas/graph.yaml#/properties/ports
>>> +
>>> + properties:
>>> + port@0:
>>> + $ref: /schemas/graph.yaml#/properties/port
>>> + description: High Speed (HS) data bus.
>>> +
>>> + port@1:
>>> + $ref: /schemas/graph.yaml#/properties/port
>>> + description: Super Speed (SS) data bus.
>>> +
>>> enable-manual-drd:
>>> $ref: /schemas/types.yaml#/definitions/flag
>>> description:
>> Reviewed-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>>
>> Thank you
>>
>
> Is everyone okay if I pick this (and the XHCI one [1]) in the MediaTek trees?
>
> This is so that I don't get devicetree warnings when picking the DT patches
> that are adding USB MUX/TCPC to the MediaTek boards.
Sound good to me.
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
--
Regards,
Alexandre
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: usb: mtu3: Add ports property
2025-02-20 14:22 [PATCH] dt-bindings: usb: mtu3: Add ports property Macpaul Lin
2025-02-20 15:56 ` AngeloGioacchino Del Regno
2025-02-22 8:35 ` Chunfeng Yun (云春峰)
@ 2025-02-25 9:02 ` AngeloGioacchino Del Regno
2 siblings, 0 replies; 7+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-02-25 9:02 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
Chunfeng Yun, Greg Kroah-Hartman, linux-usb, Alexandre Mergnat,
Macpaul Lin
Cc: Bear Wang, Pablo Sun, Macpaul Lin,
Project_Global_Chrome_Upstream_Group, Chris-qj chen
On Thu, 20 Feb 2025 22:22:30 +0800, Macpaul Lin wrote:
> Define the ports property in the mediatek,mtu3 device tree binding schema.
> Include definitions for port@0 and port@1, specifying their roles as
> High Speed (HS) and Super Speed (SS) data buses, respectively.
>
>
Applied to v6.14-next/dts64, thanks!
[1/1] dt-bindings: usb: mtu3: Add ports property
commit: 3aeff53c57c86981f9920e4d5ae7d00b7d62a671
Cheers,
Angelo
^ permalink raw reply [flat|nested] 7+ messages in thread