Re: [PATCH v2 5/7] thunderbolt: increase the lane adapter link-up timeout value

["Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>]

On 二, 2026-11-10 at 11:55 +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] thunderbolt: stale timeout in tb_wait_for_port() Return
>   kernel-doc
> --
> 
> commit 129c5b50481921f9094356b0de883693a15e937e
> Author: Chunfeng Yun <chunfeng.yun@mediatek.com>
> 
> thunderbolt: increase the lane adapter link-up timeout value
> 
> This commit increases the retry count in tb_wait_for_port() from 10
> to 20,
> extending the timeout for a port to reach TB_PORT_UP from 1 second to
> 2 seconds.
> 
> > diff --git a/drivers/thunderbolt/switch.c
> > b/drivers/thunderbolt/switch.c
> > index 7ff3da79da763..7daee83c7ed80 100644
> > --- a/drivers/thunderbolt/switch.c
> > +++ b/drivers/thunderbolt/switch.c
> > @@ -486,7 +486,7 @@ int tb_port_state(struct tb_port *port)
> >   * @port: Port to wait
> >   * @wait_if_unplugged: Wait also when port is unplugged
> >   *
> > - * Wait up to 1 second for a port to reach state TB_PORT_UP. If
> > + * Wait up to 2 seconds for a port to reach state TB_PORT_UP. If
> >   * wait_if_unplugged is set then we also wait if the port is in
> > state
> >   * TB_PORT_UNPLUGGED (it takes a while for the device to be
> > registered after
> >   * switch resume). Otherwise we only wait if a device is
> > registered but the link
> > @@ -500,7 +500,7 @@ int tb_port_state(struct tb_port *port)
> >   */
> >  int tb_wait_for_port(struct tb_port *port, bool wait_if_unplugged)
> >  {
> > -	int retries = 10;
> > +	int retries = 20;
> >  	int state;
> >  	if (!port->cap_phy) {
> >  		tb_port_WARN(port, "does not have PHY\n");
> 
> [Severity: Low]
> Should the Return section of the tb_wait_for_port() kernel-doc
> comment also
> be updated from "within one second" to two seconds?
Sure, will modify it

> 
> drivers/thunderbolt/switch.c:
>  * Return:
>  * * %0 - If the port is not connected or failed to reach
>  *   state %TB_PORT_UP within one second.
>