Re: [PATCH v7 06/12] PCI/PM: Split out code from pci_pm_suspend_noirq() into helper

[Mario Limonciello <mario.limonciello@amd.com>]

On 9/10/25 9:46 AM, Bjorn Helgaas wrote:
> On Tue, Sep 09, 2025 at 02:16:13PM -0500, Mario Limonciello (AMD) wrote:
>> In order to unify suspend and hibernate codepaths without code duplication
>> the common code should be in common helpers.  Move it from
>> pci_pm_suspend_noirq() into a helper.  No intended functional changes.
>>
>> Tested-by: Eric Naim <dnaim@cachyos.org>
>> Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
> 
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> 
> If you have other reason to repost this, ...
> 
>> +	if (pci_dev->current_state == PCI_D0) {
>> +		pci_dev->skip_bus_pm = true;
> 
> Add a blank line here.

Ack, thanks.

> 
>> +		/*
>> +		 * Per PCI PM r1.2, table 6-1, a bridge must be in D0 if any
>> +		 * downstream device is in D0, so avoid changing the power state
>> +		 * of the parent bridge by setting the skip_bus_pm flag for it.
>> +		 */
>> +		if (pci_dev->bus->self)
>> +			pci_dev->bus->self->skip_bus_pm = true;
>> +	}