From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F8757E0F6 for ; Thu, 23 May 2024 09:15:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716455735; cv=none; b=IVfP9F3Epq4KaiGsPYG8r6D/ac9mkjc96gWcRBaQeQsUMouNYqWE3WwMfATp+Hj1/D1tMQwqo/xoLANTgo53ECHak48QrspDvqUIIh8UpDjGbDIt7jaDBX5uuqiBbmfvjH7CF7vtqVc6B7fcBcyVi2DztZnNbA+/Pux4jqpMIUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716455735; c=relaxed/simple; bh=b4/uOiVZm6dCYuLpPsVUE3k95DUxAU5znaBJSv5JF1k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oiPJiT/68jmvxw49OruZS4HZQj/ZsFP/iZNLKQgOenpd0U2OBDhsYlnNay5Kff6FLkc4mu7rRltgoO0J8FZPLYNOKt4s58xOgCR1xqq0mxQqbHzgW7W0kZma9qKt6uC0SBKyyFBqpslrGu1uUtjicdEGziCv9+Gs1C0izb+2b+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=LOTqYI2J; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="LOTqYI2J" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a59ab4f60a6so976773866b.0 for ; Thu, 23 May 2024 02:15:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1716455732; x=1717060532; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b6yzAgRpwuvzYwVR75MaBk20iyXv6xLY4no1ggHk/Gg=; b=LOTqYI2JY/DJyD2p6dH7RrMUUmaTEE/UwQbd3ZdNd9II3SQa+fnUoI9k+qGQYRU6mv FCI365zh2X14z5HSLDX/c7xYwUmtWVC7vaTzDhwiSFh7Ztu42/hfMJPOtzluWevk1hJ1 9K0FSNmr6SKnj2JP5UFeaor+MsgPuDHXFnsEWi7ItGDwTwjKifVCGTKhhWSd3sk68Ffl vWzT7M3ScLz6/NLE1ZKveLRedJkvIesGb9dysPtZiSCw7yJg03KfJtODTPEyvwUU9B3L bKzJfLTd5j/iD69ROllj2XGmPhYUIoOxxpNDX3FZ1S44CHexEuColIIgjlXZc4CmNj8Z sEew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716455732; x=1717060532; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b6yzAgRpwuvzYwVR75MaBk20iyXv6xLY4no1ggHk/Gg=; b=hcQm4gpJOQ6T2a8FOmZ1kfoLBrkGUghvnGcKDFGZHAAxeDgXhQOZQpFZQ+x6OsaaBm +RWMJ80sAyhB1HUPhMm7xAuRPgFw/RmiX7vEgIfaDdIFtDhhqZe8lvgOZss+Gth/XjK3 yKM3STOZXeqpztLj0etu8zdz6rOU8zK+jIXDPCBJ8J/6jImv4kr+A67Qa7kcK5zN0XLq RIik9kpsz+Meq/ZB2IqFB3et7ov54NFTZdSvrXFqq8Y5g/dupgMj/2PLHtOQVUARnyDw 91N5+lQx3MrbouOquh6QWXYquOMmPgQTk2iKchNlbLFZVNNwgaI406QrxIutzfojbkyq 9lSw== X-Gm-Message-State: AOJu0YwXju0Tph65V2XPawZyOHNaPGGhNt31GgwrJkexS32D77XKP3Ld 1eRaA2Gz/IVcEmGvJ9HKXt/D4tGK2Uv4ZHvbBg3dB8PWNWWJYeeacP/5qB7RR4A= X-Google-Smtp-Source: AGHT+IFlK6BPcmpQgb/RasDDa8Kay+SC0dzEgMGYxnkZxxnwGN1c9iB1Q9yynHrqPd1XTTXnWvtzDw== X-Received: by 2002:a17:906:81d5:b0:a5c:e031:faf2 with SMTP id a640c23a62f3a-a622820be32mr341298966b.77.1716455731708; Thu, 23 May 2024 02:15:31 -0700 (PDT) Received: from ?IPV6:2001:a61:139b:bf01:e8eb:4d8f:8770:df82? ([2001:a61:139b:bf01:e8eb:4d8f:8770:df82]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a17b17754sm1888859766b.192.2024.05.23.02.15.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 May 2024 02:15:31 -0700 (PDT) Message-ID: Date: Thu, 23 May 2024 11:15:29 +0200 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Check whether divisor is non-zero before division To: shichao lai , Oliver Neukum , stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org, xingwei lee , yue sun References: <20240523072242.787164-1-shichaorai@gmail.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23.05.24 11:12, shichao lai wrote: > Thanks for the helpful tip! > I reviewed the code. Your suggestions can actually avoid repeated checks. > And there is also such a problem in alauda_write_lba(). > I am a beginner at making patches. May I commit a patch again which > fixes both issues you mentioned? Hi, yes, you usually are supposed to change the "[PATCH]" in the subject line to "[PATCHv2]" and add a line in the log describing the difference between the first and second version. HTH Oliver