From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.43 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794564704; b=d4Plj0h8HV7W27CLH//DV3evv/K24yRI6GW2iy/ZuSyWUnlenqAFO/0zEppeY3ah+rBn 0PNFZMSERj+TIqSMTvGhX6GjK5p0HWma3OZdykJs9syOqJxr3Ptkw0hz5YFd+ZVZ6C9Ux QQFEADr5EgCmVgRB6Mw9FfCLJtYCtCwu52oUF9iaNQ4o0uf/tyz7ONisLgXlg4bWNvrEE AlOC4reI8I9Oeq8mP4Ydu3x64H2a1r/reSu7+SahPIFA3XkOf5oJcZqZXQnU0dgoLKc1S isDlrZC2AyT5NqG17uHwZCKJpqm8vTqqHe2tTfX2LGIXLTC3540LvrTeovfh+85wfjw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794564704; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:Content-Transfer-Encoding:User-Agent:MIME-Version; bh=gXMsjTg9KyNTuX1cuQ9yr2iJq2/VClhNCtHhh+FL0ZU=; b=ZaIl3bbsayLBVrGF9QqPTTCCgdlv0muwCfYk244nNEuHeFgHu5LjhZv8cydWooFTt5hx EvOo97YsIiM17fhb3YklI2Yqv054mhb8sohmhUS2ScYLMlSDyjJ6sXRHJw+YVWhR5pNsn sGEap4tt8tOoevlekJulXczLJFhFL+ofl767C9EyHastCmDefygUP8gnolypJMBC2NZKg kMRG8Ap1NJwkDAtdMTY6TSo+Z0uVgYYiRCQ98bP6qX/YRIVX6BTl6Z5H4KFUJrwLtyt6v jrJ7g14c7vJPtSLEjfUBTs1V22e5yDV+LtKXYFfEF1gcMYebq96iF+s1aQNOpXdoG5A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=amutable.com; spf=pass smtp.mailfrom=amutable.com; dkim=pass header.d=amutable-com.20260707.gappssmtp.com header.i=@amutable-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=BADxd+iU; arc=none smtp.remote-ip=209.85.221.43 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9228C606A338 for ; Fri, 13 Nov 2026 10:11:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9228C606A338 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=amutable.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amutable.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amutable-com.20260707.gappssmtp.com header.i=@amutable-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=BADxd+iU Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-492fcbfaa88so323605f8f.3 for ; Fri, 13 Nov 2026 02:11:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amutable-com.20260707.gappssmtp.com; s=20260707; t=1794564703; x=1795169503; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=gXMsjTg9KyNTuX1cuQ9yr2iJq2/VClhNCtHhh+FL0ZU=; b=BADxd+iUI5Bylfm9xHmZjb4pgHg0fbyWkyp8vNCt747iYknkt4pGGRNYLQ78EH/z4x Vbi/Jq3+E8iOs58TJRk6WPlWSpFf2OpeZbjgHeXjXzKeHm9XnJ+eEvU2VLt6liCBRq7I 79Td6VY4SiSTAXWOIivpd5ztVkC+DBAB/J4OfHn49+YeU7s/KQ9yNfnwb8sPZOTKoGu0 Zirp8LScbJznGaQAXzatlGuiy/pBfqScnET/jGobuhYjlwMbyAqyeVJ7smTe1nJkO+dB h89eeA8CIS4pNdPKyjqDo55n+EKX5qBSzrC2C/95dZzzzQLBvHRJ+46c+P8Bzg/7r93a +u0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794564703; x=1795169503; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gXMsjTg9KyNTuX1cuQ9yr2iJq2/VClhNCtHhh+FL0ZU=; b=f9CA7B9agI/c7bNxPROFsFaR2ZgJkwn4nfjRU7hztcPEq6o+8fI/UdWUSjk/Zpmorg yseTDtl40zp8q2qUTyQ1EDby0J78jFbMhL1oOlsqM28B5tGT3fR2eAIbubJj8qM28Lje NWJHBLQnXLZWv4c4KLspUhYDXGjoYARPXKJHkAwLx9NDMdqlSfLr9b1cNZUjjiAI4T1g Xp1pv9Nns/JYK/wufmP4KKhx+8SH7XJHwz3ZdggHSPAlbHdW8o+G27nIVA0fEnbM21QA hgTBFkpi09l1uBHM0ouEQDH13P0JlFaRt3/NWZo4LP4r26gK8RDG36sGDAg5bWqkwOS1 +bGw== X-Forwarded-Encrypted: i=1; AL+hErFxNtfdiAuBcrxxbyV61X2GjiD075jAwVG/Gr4g3/9RR86OPaKRp7QG/xsZBgwoTxDl7NutRlp6SE0=@vger.kernel.org X-Gm-Message-State: APuU4Z890xqN4xd0IZLprfLAizkMZ7aKmy6mdyWA+Ti5uiihkoMxKrOK AzqWWbOnLZ/Z6RPuiILSBN1ALgi6IAA8n8dXVv5zU947CP+cxGoKjl3oLQ3yR2/K4YTB X-Gm-Gg: AYBFou17CoHKOrrPcvj63pHHmgLMCZPwI9iEmL93Q6/6UVpQbkZ9/8Tcnw5Z8nkresF hV8d2c+DA4qveB0S7ea1D+kt/WPplXI4mSR3hil8TAE/rb4Yf5axIbQEXE3TOGVeRgQSv4TBDyT gB2ciTvtu4cBC1RLiQkyrhIyPd3Rhv+NNVkdVDspjLDQpf512u5VfIqCgQtsZE4Kp0fpgfy9TJh 1qAzn0Sz/tNfvWKD+kMe3WiIpohxsk/OJUhr2J6B9QP/ePS18ee77mVnSSKv5cY9MbOdgkWZzlh IxN/ElTLbcuO2rwOMW52WtEq+sLB+rc0Xc9zvF18zlpUnaPaarDj8v9KdBtn8VSqty5Y2OdMgqH 3xpNM3lexWXRCoyvNBbvHwifX4TXgLW4CFhZXJ6RlncpW1SC2t0E1AMoK1jotcG5f8BC88wnoNe AdLlG+RXLn61SNcWO3gGUaSbK64DcjldaXvAKRZ33JK5dUKVwX+aQNlkrVzkgPS/Yrp7/Gs7tEI PE+JjCLb99r6ANQP6dZD1NFNzczxAoxJqMnHrxxxubKKSP3JK4td7OPLi09oI8usRlr68dltyQQ c00XCDqePOOXJHhm/BXLzkseeoX89pmRVC1NaTX/oebEpT8ZrndmiemDUEbnHr4= X-Received: by 2002:a05:6000:2501:b0:488:88ec:59c3 with SMTP id ffacd0b85a97d-49c73259cc3mr5012611f8f.14.1794564703010; Fri, 13 Nov 2026 02:11:43 -0800 (PST) Received: from [10.0.0.233] (tmo-086-54.customers.d1-online.com. [80.187.86.54]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-49c5f1c1797sm4931434f8f.11.2026.11.13.02.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 02:11:42 -0800 (PST) Message-ID: Subject: Re: [PATCH RFC 18/41] selinux: use fc_init_pseudo() for selinuxfs From: Alexander Mikhalitsyn To: Christian Brauner , linux-fsdevel@vger.kernel.org Cc: Jann Horn , Chris Mason , Josef Bacik , Christoph Hellwig , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Alexander Viro , Jan Kara , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, driver-core@lists.linux.dev, linux-mm@kvack.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, apparmor@lists.ubuntu.com, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, fuse-devel@lists.linux.dev, linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org, ocfs2-devel@lists.linux.dev, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-usb@vger.kernel.org, Amir Goldstein , linux-erofs@lists.ozlabs.org, linux-kselftest@vger.kernel.org Date: Fri, 13 Nov 2026 11:11:40 +0100 In-Reply-To: <20261110-work-loop-pseudo-v1-18-4c998976c6c7@kernel.org> References: <20261110-work-loop-pseudo-v1-0-4c998976c6c7@kernel.org> <20261110-work-loop-pseudo-v1-18-4c998976c6c7@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 On Tue, 2026-11-10 at 10:14 +0100, Christian Brauner wrote: > Initialize selinuxfs as a pseudo filesystem. This raises SB_I_PSEUDO > and > SB_I_NOEXEC. selinuxfs never holds executables. SB_I_NOEXEC also > refuses PROT_EXEC mappings but the status and policy files are only > ever mapped for reading. >=20 > But selinuxfs needs device nodes. The kernel replaces file > descriptors > with /sys/fs/selinux/null on exec via dentry_open() which doesn't > care > about SB_I_NODEV. Android init however opens /sys/fs/selinux/null by > path as /dev/null doesn't exist yet at that point. So clear > SB_I_NODEV > again in sel_fill_super(). >=20 > Signed-off-by: Christian Brauner (Amutable) Reviewed-by: Alexander Mikhalitsyn I.=20 > --- > =C2=A0security/selinux/selinuxfs.c | 5 +++++ > =C2=A01 file changed, 5 insertions(+) >=20 > diff --git a/security/selinux/selinuxfs.c > b/security/selinux/selinuxfs.c > index 310e19efff1d..d7ae853b6d68 100644 > --- a/security/selinux/selinuxfs.c > +++ b/security/selinux/selinuxfs.c > @@ -18,6 +18,7 @@ > =C2=A0#include > =C2=A0#include > =C2=A0#include > +#include > =C2=A0#include > =C2=A0#include > =C2=A0#include > @@ -1852,6 +1853,9 @@ static int sel_fill_super(struct super_block > *sb, struct fs_context *fc) > =C2=A0 /* last one */ {"", NULL, 0} > =C2=A0 }; > =C2=A0 > + /* Android init opens the null device below by path. */ > + sb->s_iflags &=3D ~SB_I_NODEV; > + > =C2=A0 ret =3D selinux_fs_info_create(sb); > =C2=A0 if (ret) > =C2=A0 goto err; > @@ -1955,6 +1959,7 @@ static const struct fs_context_operations > sel_context_ops =3D { > =C2=A0 > =C2=A0static int sel_init_fs_context(struct fs_context *fc) > =C2=A0{ > + fc_init_pseudo(fc); > =C2=A0 fc->ops =3D &sel_context_ops; > =C2=A0 return 0; > =C2=A0}