From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 567B512E1CC for ; Mon, 26 Feb 2024 18:14:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708971249; cv=none; b=hwYsgli1X3KZr0C9qq0m2/3Ks2k7whY2yfqMbosX7jRDJpkJLR3/15Wy1hhZWCqEn4NsJoAUYVJ+v4MJxVuVuIGehgHE/L4xk9pR2ZY8WKodCz5fzcSoLdHy5XKpbX1fFsI9TSB7+6IfRiP1cNzCSNxc0ZTx6VFpv0F1obIph60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708971249; c=relaxed/simple; bh=jvztlj2fOBuagAeUU8MHaIuRSoRjQLL3omt64QErqFk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=XqKV9EOnYAzzgZK5hXGO1jX69vjcY3Gx/8NemfZ7ilr9PCXvYA0W3E0wOdiDTR1hGtsI1roXuNNojtNok3fukzNI9FUmDyqTYqNXi8r4d9hWQMtKN65VnmtnbT0fvVt2eHz05anmN2unWsup/Rf58kdZKpc72PfHXKxUpKbh9f4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IDkyR1pW; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IDkyR1pW" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-33d6cc6d2fcso2159171f8f.2 for ; Mon, 26 Feb 2024 10:14:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708971246; x=1709576046; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=rdOlnisLBpgn2tY4M92YMommU1ind5HDlDhk0k1dAms=; b=IDkyR1pW8ChSsmgSDgCrCtd9tXDSkuaVXK6aGF8RCmymEvGQukXH8c6LHRwmLL1eW7 MOVJ4D+EzPSTFbaQoOJc3ASI6veG/5K8OoZRrOzTLC05/wxX9XoqLsw579UTs4ZiFYag B/r/U2ZQA8450ogF9zjyFDyuy7eU0qlxXqiDkutmgee9z/hrpouQT48APEHk+/WpXhqY wrnHKg0aWrynLQy9qgIkTfvUQ8GN0xKo3i6DuqATijgO3XVgDM4kSncU/E+YuTqlh+bO 2y9sDBfDvXSFd+yVq4RwiZutUVKY48BrbZbFl7Dz377mgT7KMK0SqdRjcO260b9rkPdj ndpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708971246; x=1709576046; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rdOlnisLBpgn2tY4M92YMommU1ind5HDlDhk0k1dAms=; b=TPwY7DSkiwisUB5Obs+7MtG0sj31ztTQU6iyyrOyZA5LC9sQCyd2d3Dmki6NaA7XxV zJ7zXqMlYVWSYEA/nB9L5stjTTM6kzeD2x9RIhGaRYnfquNhDQLYn95E89r89KFhlQP0 7Z9i8FPfTTKSb1U3dfd4iNjT/YGpocpd/oeCUpZjhpdrcdzt8dsD1BZP5ztYk0SnQRux wc1I2sUmISxXReJB2F5VclKpNTlX5wXDmh9yivdsCiiST5zuM4WWIsixJjEY3BUyyRk2 zNGkoQvOk0YQAALBrSsnlZHgUhmId6nMRfwhz8zzXQvWXctlHip0vkDR1Vxgd8VHMcTx BP2w== X-Gm-Message-State: AOJu0YydBH+bNXo3cMVR/52GlEr/lT7CUmhn301fmzG8bqxGWvWWMaeZ iKAy4+d7dsXNJZgvIQUMllpTg4k6b3L15jkcHazKLTcm6RVy96ap5yXMBZnq0cU= X-Google-Smtp-Source: AGHT+IFPy8PQ+Y6ALtHBB46D50zSvTEsaf8HgqKvkKq5krJix8fiZnDh+U3QAloD0ksGoobusBm3aw== X-Received: by 2002:a05:6000:12d0:b0:33d:6554:fe81 with SMTP id l16-20020a05600012d000b0033d6554fe81mr4990641wrx.64.1708971245802; Mon, 26 Feb 2024 10:14:05 -0800 (PST) Received: from localhost (a109-49-32-45.cpe.netcabo.pt. [109.49.32.45]) by smtp.gmail.com with ESMTPSA id h4-20020a05600016c400b0033dda0e82e5sm3542919wrf.32.2024.02.26.10.14.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 10:14:05 -0800 (PST) From: Rui Miguel Silva To: Chengming Zhou , gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, vbabka@suse.cz, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com Subject: Re: [PATCH] usb: isp1760: remove SLAB_MEM_SPREAD flag usage In-Reply-To: References: <20240224135256.830413-1-chengming.zhou@linux.dev> Date: Mon, 26 Feb 2024 18:14:04 +0000 Message-ID: Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Hey Zhou, many thanks for the patch. Chengming Zhou writes: > On 2024/2/24 21:52, chengming.zhou@linux.dev wrote: >> From: Chengming Zhou >> >> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove >> its usage so we can delete it from slab. No functional change. > > Update changelog to make it clearer: > > The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was > removed as of v6.8-rc1, so it became a dead flag since the commit > 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the > series[1] went on to mark it obsolete to avoid confusion for users. > Here we can just remove all its users, which has no functional change. > > [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ With this changelog, you can add my tag: Acked-by: Rui Miguel Silva Cheers, Rui > > Thanks! > >> >> Signed-off-by: Chengming Zhou >> --- >> drivers/usb/isp1760/isp1760-hcd.c | 8 +++----- >> 1 file changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c >> index 76862ba40f35..0e5e4cb74c87 100644 >> --- a/drivers/usb/isp1760/isp1760-hcd.c >> +++ b/drivers/usb/isp1760/isp1760-hcd.c >> @@ -2521,21 +2521,19 @@ static const struct hc_driver isp1760_hc_driver = { >> int __init isp1760_init_kmem_once(void) >> { >> urb_listitem_cachep = kmem_cache_create("isp1760_urb_listitem", >> - sizeof(struct urb_listitem), 0, SLAB_TEMPORARY | >> - SLAB_MEM_SPREAD, NULL); >> + sizeof(struct urb_listitem), 0, SLAB_TEMPORARY, NULL); >> >> if (!urb_listitem_cachep) >> return -ENOMEM; >> >> qtd_cachep = kmem_cache_create("isp1760_qtd", >> - sizeof(struct isp1760_qtd), 0, SLAB_TEMPORARY | >> - SLAB_MEM_SPREAD, NULL); >> + sizeof(struct isp1760_qtd), 0, SLAB_TEMPORARY, NULL); >> >> if (!qtd_cachep) >> goto destroy_urb_listitem; >> >> qh_cachep = kmem_cache_create("isp1760_qh", sizeof(struct isp1760_qh), >> - 0, SLAB_TEMPORARY | SLAB_MEM_SPREAD, NULL); >> + 0, SLAB_TEMPORARY, NULL); >> >> if (!qh_cachep) >> goto destroy_qtd;