From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BF6DC6369E for ; Wed, 18 Nov 2020 07:34:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31E2D2466D for ; Wed, 18 Nov 2020 07:34:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726506AbgKRHe2 (ORCPT ); Wed, 18 Nov 2020 02:34:28 -0500 Received: from mx2.suse.de ([195.135.220.15]:48366 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725794AbgKRHe2 (ORCPT ); Wed, 18 Nov 2020 02:34:28 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5041EABDE; Wed, 18 Nov 2020 07:34:26 +0000 (UTC) Date: Wed, 18 Nov 2020 08:34:25 +0100 Message-ID: From: Takashi Iwai To: Macpaul Lin Cc: Takashi Iwai , Jaroslav Kysela , Matthias Brugger , Alexander Tsoy , "Nicola Lunghi" , Christopher Swenson , Nick Kossifidis , "alsa-devel@alsa-project.org" , Ainge Hsu (=?UTF-8?B?5b6Q5ben5a6c?=) , Eddie Hung (=?UTF-8?B?5rSq5q2j6ZGr?=) , Chunfeng Yun (=?UTF-8?B?5LqR5pil5bOw?=) , wsd_upstream , Macpaul Lin , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-usb@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "stable@vger.kernel.org" Subject: Re: [PATCH v3] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET In-Reply-To: <1605677166.23663.4.camel@mtkswgap22> References: <1604996266.2817.1.camel@mtkswgap22> <1604999048-20294-1-git-send-email-macpaul.lin@mediatek.com> <1605677166.23663.4.camel@mtkswgap22> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, 18 Nov 2020 06:26:06 +0100, Macpaul Lin wrote: > > On Tue, 2020-11-10 at 17:04 +0800, Macpaul Lin wrote: > > The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports > > 96khz. However there will be some random issue under 96khz. > > Not sure if there is any alternate setting could be applied. > > Hence 48khz is suggested to be applied at this moment. > > > > Signed-off-by: Macpaul Lin > > Signed-off-by: Eddie Hung > > Cc: stable@vger.kernel.org > > --- > > Changes for v2: > > - Fix build error. > > - Add Cc: stable@vger.kernel.org > > Changes for v3: > > - Replace "udev" with "chip->dev" according to Takashi's suggestion. Thanks. > > > > sound/usb/format.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/sound/usb/format.c b/sound/usb/format.c > > index 1b28d01..0aff774 100644 > > --- a/sound/usb/format.c > > +++ b/sound/usb/format.c > > @@ -217,6 +217,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof > > (chip->usb_id == USB_ID(0x041e, 0x4064) || > > chip->usb_id == USB_ID(0x041e, 0x4068))) > > rate = 8000; > > + /* Huawei headset can't support 96kHz fully */ > > + if (rate == 96000 && > > + chip->usb_id == USB_ID(0x12d1, 0x3a07) && > > + le16_to_cpu(chip->dev->descriptor.bcdDevice) == 0x49) > > + continue; > > > > fp->rate_table[fp->nr_rates] = rate; > > if (!fp->rate_min || rate < fp->rate_min) > > Sorry for bothering again, please hold-on this patch. > I'm still trying to clarify if there is another approach for this > interoperability issue. > I'll update this thread once the result has came out. OK, thanks for information. Takashi