From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53813C433EF for ; Mon, 11 Oct 2021 16:07:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EAED60EB1 for ; Mon, 11 Oct 2021 16:07:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231197AbhJKQJD (ORCPT ); Mon, 11 Oct 2021 12:09:03 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:44646 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230152AbhJKQJD (ORCPT ); Mon, 11 Oct 2021 12:09:03 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id ED8E422114; Mon, 11 Oct 2021 16:07:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1633968421; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hUpQYqN5r29YnnBS8Aw3gLg+1IeYzv6/vancdzpN1BA=; b=l4w4XSBnXWVLGwXZZgFxVxd916j3iHz7DMtfPJ8X+zj+kSvx2/V1Dq7TBwy5nT5GMTn1Cn TC84tWjG5yqZQ0nPGmkrfNrWhScoeo3asvYkKT+er8rKSnh2TnGKf1LvC1eQPujjOED3AA PIgpHPQEuaiaRm0zYQXQgahVCDUFN54= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1633968421; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hUpQYqN5r29YnnBS8Aw3gLg+1IeYzv6/vancdzpN1BA=; b=PVpe5pMSM/GwhrdNsue8j0RnxfFG8dgEePsmUenoSbYa3h1LGYJ/VzhVlRreELCdWSBG0H j+5FwwYh/8cPGEAw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id CD880A3B8C; Mon, 11 Oct 2021 16:07:01 +0000 (UTC) Date: Mon, 11 Oct 2021 18:07:01 +0200 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: allow -EPIPE errors for some v2 messages In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, 11 Oct 2021 17:28:15 +0200, Greg Kroah-Hartman wrote: > > On Sun, Oct 10, 2021 at 10:25:09PM +0200, Takashi Iwai wrote: > > On Sun, 10 Oct 2021 14:22:41 +0200, > > Greg Kroah-Hartman wrote: > > > > > > The Schiit Hel device does not like to respond to all get_ctl_value_v2() > > > requests for some reason. This used to work in older kernels, but now > > > with more strict checking, this failure causes the device to fail to > > > work. > > > > > > Cc: Jaroslav Kysela > > > Cc: Takashi Iwai > > > Signed-off-by: Greg Kroah-Hartman > > > --- > > > > > > This fixes the Shiit Hel device that I have. It used to work on older > > > kernels (a year ago?), but stopped working for some reason and I didn't > > > take the time to track it down. This change fixes the issue for me, but > > > feels wrong for some reason. At least now I can use the device as a > > > headphone driver, much better than the built-in one for my current > > > machine... > > > > > > If needed, I can take the time to do bisection to track down the real > > > issue here, it might be due to stricter endpoint checking in the USB > > > core, but that feels wrong somehow. > > > > > > Here's the debugfs USB output for this device, showing the endpoints: > > > > > > T: Bus=07 Lev=02 Prnt=02 Port=01 Cnt=01 Dev#= 5 Spd=480 MxCh= 0 > > > D: Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > > > P: Vendor=30be ProdID=0101 Rev=01.02 > > > S: Manufacturer=Schiit Audio > > > S: Product=Schiit Hel > > > C: #Ifs= 4 Cfg#= 1 Atr=c0 MxPwr=0mA > > > I: If#= 0 Alt= 0 #EPs= 1 Cls=01(audio) Sub=01 Prot=20 Driver=snd-usb-audio > > > E: Ad=8f(I) Atr=03(Int.) MxPS= 6 Ivl=1ms > > > I: If#= 1 Alt= 1 #EPs= 2 Cls=01(audio) Sub=02 Prot=20 Driver=snd-usb-audio > > > E: Ad=05(O) Atr=05(Isoc) MxPS= 104 Ivl=125us > > > E: Ad=85(I) Atr=11(Isoc) MxPS= 4 Ivl=1ms > > > I: If#= 2 Alt= 1 #EPs= 1 Cls=01(audio) Sub=02 Prot=20 Driver=snd-usb-audio > > > E: Ad=88(I) Atr=05(Isoc) MxPS= 156 Ivl=125us > > > I: If#= 3 Alt= 0 #EPs= 1 Cls=03(HID ) Sub=00 Prot=00 Driver=usbhid > > > E: Ad=84(I) Atr=03(Int.) MxPS= 16 Ivl=1ms > > > > > > Any other suggestions to fix this are welcome. > > > > Could you show the exact error messages and lsusb -v output? > > We may paper over only the problematic node instead. > > Sure, here's the dmesg output on 5.15-rc5 when it is turned on: > > [Oct11 17:25] usb 7-2.2: new high-speed USB device number 9 using xhci_hcd > [ +0.122422] usb 7-2.2: New USB device found, idVendor=30be, idProduct=0101, bcdDevice= 1.02 > [ +0.000009] usb 7-2.2: New USB device strings: Mfr=1, Product=2, SerialNumber=0 > [ +0.000002] usb 7-2.2: Product: Schiit Hel > [ +0.000002] usb 7-2.2: Manufacturer: Schiit Audio > [ +0.327172] input: Schiit Audio Schiit Hel as /devices/pci0000:40/0000:40:01.1/0000:41:00.0/0000:42:08.0/0000:47:00.1/usb7/7-2/7-2.2/7-2.2:1.3/0003:30BE:0101.0009/input/input21 > [ +0.055134] hid-generic 0003:30BE:0101.0009: input,hidraw8: USB HID v1.00 Device [Schiit Audio Schiit Hel] on usb-0000:47:00.1-2.2/input3 > [ +0.135988] usb 7-2.2: cannot get ctl value: req = 0x81, wValue = 0x100, wIndex = 0x1100, type = 1 > [ +0.060647] usb 7-2.2: cannot get ctl value: req = 0x81, wValue = 0x100, wIndex = 0x1100, type = 1 > [ +0.065362] usb 7-2.2: cannot get ctl value: req = 0x81, wValue = 0x100, wIndex = 0x1100, type = 1 > [ +0.192121] usb 7-2.2: cannot get ctl value: req = 0x81, wValue = 0x100, wIndex = 0x1100, type = 1 Thanks. So this happens at the unit 17, and ... > And here is the 'lsusb -v' output of the device. > > > Bus 007 Device 009: ID 30be:0101 Schiit Audio Schiit Hel (snip) > AudioControl Interface Descriptor: > bLength 18 > bDescriptorType 36 > bDescriptorSubtype 6 (FEATURE_UNIT) > bUnitID 17 > bSourceID 5 > bmaControls(0) 0x00000003 > Mute Control (read/write) > bmaControls(1) 0x00000000 > bmaControls(2) 0x00000000 > iFeature 0 ... this is the entry. Could you also post the contents of /proc/asound/card*/usbmixer (only for the corresponding device), too? thanks, Takashi