From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E64D6C5517A for ; Tue, 10 Nov 2020 08:24:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A181720870 for ; Tue, 10 Nov 2020 08:24:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727711AbgKJIYW (ORCPT ); Tue, 10 Nov 2020 03:24:22 -0500 Received: from mx2.suse.de ([195.135.220.15]:52372 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726690AbgKJIYW (ORCPT ); Tue, 10 Nov 2020 03:24:22 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4D23FAB95; Tue, 10 Nov 2020 08:24:20 +0000 (UTC) Date: Tue, 10 Nov 2020 09:24:20 +0100 Message-ID: From: Takashi Iwai To: Macpaul Lin Cc: Jaroslav Kysela , Takashi Iwai , Matthias Brugger , Alexander Tsoy , Nicola Lunghi , "Christopher Swenson" , Nick Kossifidis , , Ainge Hsu , Eddie Hung , Chunfeng Yun , Mediatek WSD Upstream , Macpaul Lin , , , , Subject: Re: [PATCH] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET In-Reply-To: <1604996266.2817.1.camel@mtkswgap22> References: <1604995443-30453-1-git-send-email-macpaul.lin@mediatek.com> <1604996266.2817.1.camel@mtkswgap22> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, 10 Nov 2020 09:17:46 +0100, Macpaul Lin wrote: > > On Tue, 2020-11-10 at 09:12 +0100, Takashi Iwai wrote: > > On Tue, 10 Nov 2020 09:04:03 +0100, > > Macpaul Lin wrote: > > > > > > The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports > > > 96khz. However there will be some random issue under 96khz. > > > Not sure if there is any alternate setting could be applied. > > > Hence 48khz is suggested to be applied at this moment. > > > > > > Signed-off-by: Macpaul Lin > > > Signed-off-by: Eddie Hung > > > --- > > > sound/usb/format.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/sound/usb/format.c b/sound/usb/format.c > > > index 1b28d01..6f6e79b 100644 > > > --- a/sound/usb/format.c > > > +++ b/sound/usb/format.c > > > @@ -217,6 +217,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof > > > (chip->usb_id == USB_ID(0x041e, 0x4064) || > > > chip->usb_id == USB_ID(0x041e, 0x4068))) > > > rate = 8000; > > > + /* Huawei headset can't support 96kHz fully */ > > > + if (rate == 96000 && > > > + chip->usb_id == USB_ID(0x12d1, 0x3a07) && > > > + le16_to_cpu(udev->descriptor.bcdDevice) == 0x49) > > > > This causes the compile error due to the unknown udev. > > Is this bcdDevice check mandatory? > > This means firmware version of the headset as far as I know.. OK, then it's useful. > Sorry I'll check the compile error and resend later. I guess the only needed change is to replace udev with chip->dev. thanks, Takashi > > > > > thanks, > > > > Takashi > > Thanks > Macpaul Lin >