From: sashiko-bot@kernel.org
To: "Niklas Neronin" <niklas.neronin@linux.intel.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH 3/5] usb: xhci: remove redundant TT active EP update from xhci_free_virt_device()
Date: Tue, 06 Oct 2026 16:41:49 +0000 [thread overview]
Message-ID: <sashiko-outbox-162264@kernel.org> (raw)
In-Reply-To: <20261006152427.3735383-4-niklas.neronin@linux.intel.com>
> Function xhci_free_virt_device() saves 'tt_info->active_eps' and later
> calls xhci_update_tt_active_eps().
>
> However, xhci_update_tt_active_eps() only updates TT accounting when the
> number of active endpoints changes. xhci_free_virt_device() does not add
> or remove endpoints and therefore leaves 'tt_info->active_eps' unchanged.
> As a result, the call to xhci_update_tt_active_eps() never modifies any
> state.
>
> Remove the unused active endpoint tracking and the redundant call.
>
> In cases where virtual devices are freed without first dropping their
> endpoints, xhci_rh_bw_cleanup() resets all bandwidth accounting data,
> making the update unnecessary.
>
> Signed-off-by: Niklas Neronin <niklas.neronin@linux.intel.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261006152427.3735383-1-niklas.neronin@linux.intel.com?part=3
next prev parent reply other threads:[~2026-10-06 16:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 15:24 [PATCH 0/5] usb: xhci: bandwidth accounting fixes and cleanup Niklas Neronin
2026-10-06 15:24 ` [PATCH 1/5] usb: xhci: clear stale bandwidth data after hibernation Niklas Neronin
2026-10-06 16:12 ` Michal Pecio
2026-10-06 16:22 ` sashiko-bot
2026-10-06 15:24 ` [PATCH 2/5] usb: xhci: correct num_active_eps accounting on allocation failure Niklas Neronin
2026-10-06 16:29 ` sashiko-bot
2026-10-06 16:33 ` Michal Pecio
2026-10-06 21:02 ` Michal Pecio
2026-10-07 9:28 ` Neronin, Niklas
2026-10-06 15:24 ` [PATCH 3/5] usb: xhci: remove redundant TT active EP update from xhci_free_virt_device() Niklas Neronin
2026-10-06 16:41 ` sashiko-bot [this message]
2026-10-06 15:24 ` [PATCH 4/5] usb: xhci: correct variable size conversion Niklas Neronin
2026-10-06 16:46 ` sashiko-bot
2026-10-06 15:24 ` [PATCH 5/5] usb: xhci: remove unused structs Niklas Neronin
2026-10-06 16:47 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-162264@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=niklas.neronin@linux.intel.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox