From: sashiko-bot@kernel.org
To: "Runyu Xiao" <runyu.xiao@seu.edu.cn>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: pxa25x: mark the watchdog timer IRQ-safe
Date: Fri, 09 Oct 2026 03:26:58 +0000 [thread overview]
Message-ID: <sashiko-outbox-164759@kernel.org> (raw)
In-Reply-To: <20261009031318.1122589-1-runyu.xiao@seu.edu.cn>
> The PXA25x UDC reset path runs from its hard-IRQ handler and calls
> timer_delete_sync() for the watchdog. The timer is currently initialized
> without TIMER_IRQSAFE, so timer_delete_sync() warns and can deadlock when
> the reset races with the watchdog callback.
>
> Mark the timer IRQ-safe. Since IRQ-safe callbacks run with interrupts
> disabled and remain so on return, remove the callback's local IRQ disable
> and enable pair; local_irq_enable() would otherwise re-enable interrupts
> before the callback returns.
>
> Fixes: 8fa7292fee5c ("treewide: Switch/rename to timer_delete[_sync]()")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Runyu Xiao <runyu.xiao@seu.edu.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261009031318.1122589-1-runyu.xiao@seu.edu.cn?part=1
prev parent reply other threads:[~2026-10-09 3:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 3:13 [PATCH] usb: gadget: pxa25x: mark the watchdog timer IRQ-safe Runyu Xiao
2026-10-09 3:26 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-164759@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=runyu.xiao@seu.edu.cn \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox