Re: [PATCH net-next v6 04/10] r8152: split rtl8156_enable/up/down into per-chip-family functions

[sashiko-bot@kernel.org]

> rtl8156_enable(), rtl8156_up() and rtl8156_down() had accumulated
> tp->version range checks to cover RTL8156, RTL8156B, and
> RTL8157/RTL8159, including an early bail-out in rtl8156_enable()
> that skipped most of the function body for RTL8157/RTL8159. The
> result hides which settings belong to which chip, so chip-specific
> register differences cannot be reviewed, and cannot be added without
> touching the other families.
> 
> Give each family its own ops callback: rtl8156b_enable() for
> VER_12/13/15, and rtl8157_enable()/rtl8157_up()/rtl8157_down() for
> VER_16/17. rtl8156_enable() keeps serving RTL8156 (VER_10/11) and
> rtl8156_up()/rtl8156_down() keep serving RTL8156 and RTL8156B
> (VER_10/11/12/13/15).
> 
> Each extracted function reproduces what its chips already did, with
> the guards that were true for them inlined and the ones that were
> false dropped as unreachable. The one judgement call is
> r8156_fc_parameter(): its "tp->version < RTL_VER_12" guard becomes
> unreachable in rtl8156b_enable(), so the call is dropped rather than
> carried over as dead code.
> 
> No functional change intended.
> 
> Signed-off-by: Chih Kai Hsu <hsu.chih.kai@realtek.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008081556.47901-1-nic_swsd@realtek.com?part=4