Re: [PATCH v3 2/2] usb: uas: add US_FL_QDEPTH_075 quirk to cap queue depth at probe time

[sashiko-bot@kernel.org]

> The previous patch in this series ("usb: uas: implement
> .change_queue_depth to allow per-device queue depth override") lets
> userspace lower a device's queue depth via the standard sysfs
> attribute, but only after udev has had a chance to act. That still
> leaves a window between probe and udev's write where the device runs
> at the full default depth.
> 
> This adds US_FL_QDEPTH_075: it caps can_queue to 3/4 of the device's
> reported maximum directly in uas_probe(), closing that window for
> devices that need it. Applied here to the Lexar ES3 enclosure
> (21c4:0003) from the previous patch.
> 
> v3: Sashiko AI review found two real issues in v2 (first version of
>     this patch, sent alongside v2 of patch 1), both fixed:
> 
> [ ... ]
>       from udev.
>     - Mixed 70/30 read/write load: 614MB/s read + 263MB/s write, zero
>       events.
> 
> Signed-off-by: Luca Cecchi <luca.cecchi.info@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009081225.304319-1-luca.cecchi.info@gmail.com?part=2