Re: [PATCH 08/14] usb: xhci-pci: Add TUSB73x0 definitions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] usb: incomplete refactoring of TUSB73x0 PCI ID magic number
--

commit 876cce743788b879e20245be68d1112387a5be14
Author: Fabio Estevam <festevam@gmail.com>

usb: xhci-pci: Add TUSB73x0 definitions

This patch introduces definitions for the TUSB73X0 PCI ID, USB_CTRL register
address, and PWRON_POLARITY. This replaces the hard-coded values in the
code to improve readability.

> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index a8889081ae824..c580e0b860118 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
[ ... ]
> @@ -95,6 +98,8 @@
>  #define PCI_DEVICE_ID_ASMEDIA_3042_XHCI			0x3042
>  #define PCI_DEVICE_ID_ASMEDIA_3242_XHCI			0x3242
>  
> +#define PCI_DEVICE_ID_TI_TUSB73X0			0x8241

[Severity: Low]
Does this code leave an incomplete refactoring of the magic number 0x8241?

In drivers/usb/host/pci-quirks.c:quirk_usb_handoff_xhci(), the TI TUSB73X0 PCI
device ID is still hard-coded:

drivers/usb/host/pci-quirks.c:quirk_usb_handoff_xhci() {
    ...
    if ((pdev->vendor == PCI_VENDOR_ID_TI && pdev->device == 0x8241) ||
    ...
}

Should PCI_DEVICE_ID_TI_TUSB73X0 be placed in a shared header so it can replace
the hard-coded value in both files?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009095834.561578-1-mathias.nyman@linux.intel.com?part=8