From: sashiko-bot@kernel.org
To: "Sasha Levin" <sashal@kernel.org>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] tools: usb: ffs-test: read the descriptor counts with unaligned accesses
Date: Sun, 11 Oct 2026 23:54:05 +0000 [thread overview]
Message-ID: <sashiko-outbox-167523@kernel.org> (raw)
In-Reply-To: <20261011234707.2475490-1-sashal@kernel.org>
> descs_to_legacy() reads the descriptor counts through a __le32 pointer
> taken from a member of a packed struct, which may be unaligned:
>
> ffs-test.c:235:40: warning: taking address of packed member of 'struct <anonymous>' may result in an unaligned pointer value [-Waddress-of-packed-member]
>
> Walk the counts with a byte pointer and get_unaligned_le32().
>
> Fixes: b9a4274699c69 ("tools: ffs-test: add compatibility code for old kernels")
> Assisted-by: LLM
> Signed-off-by: Sasha Levin <sashal@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261011234707.2475490-1-sashal@kernel.org?part=1
next prev parent reply other threads:[~2026-10-11 23:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 22:34 [PATCH] tools: usb: ffs-test: read the descriptor counts with unaligned accesses Sasha Levin
2026-10-11 22:41 ` sashiko-bot
2026-10-11 23:09 ` Michał Nazarewicz
2026-10-11 23:47 ` [PATCH v2] " Sasha Levin
2026-10-11 23:54 ` sashiko-bot [this message]
2026-10-13 2:14 ` Michał Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-167523@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox