Re: [PATCH 04/11] dt-bindings: usb: Add NVIDIA LSTP USB adapter

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing required interrupt-controller properties for GPIO variant
--

commit e512df165fd25f0219b3ca663151d385bd684eb0
Author: Adrian Ambrozewicz <aambrozewicz@nvidia.com>

dt-bindings: usb: Add NVIDIA LSTP USB adapter

This commit adds the device tree bindings for the NVIDIA LSTP USB adapter. The
device multiplexes multiple channels over one USB interface and reports its
channels itself. The bindings allow describing peripherals on the buses, GPIO
lines, and LEDs that cannot be reported automatically.

> diff --git a/Documentation/devicetree/bindings/usb/nvidia,lstp.yaml b/Documentation/devicetree/bindings/usb/nvidia,lstp.yaml
> new file mode 100644
> index 0000000000000..62b21051ab20e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/nvidia,lstp.yaml
[ ... ]
> +                    i2c@2 {
> +                        compatible = "nvidia,lstp-i2c";
> +                        reg = <2>;
> +                        #address-cells = <1>;
> +                        #size-cells = <0>;
> +
> +                        temperature-sensor@48 {
> +                            compatible = "ti,tmp102";
> +                            reg = <0x48>;
> +                        };
> +                    };
> +
> +                    gpio@3 {
> +                        compatible = "nvidia,lstp-gpio";
> +                        reg = <3>;
> +                        gpio-controller;
> +                        #gpio-cells = <2>;
> +                        gpio-line-names = "LED", "INT";
> +                    };

[Severity: Low]
Does this example omit the mandatory interrupt controller properties for this
GPIO variant?

The Device Tree Bindings guidelines state that when a hardware variant acts as
an interrupt controller, it must define the capabilities in the required
properties list. It appears the schema in
Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml incorrectly
classifies these as dependent instead of required:

Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml:
dependentRequired:
  interrupt-controller: ["#interrupt-cells"]
  "#interrupt-cells": [interrupt-controller]

required:
  - compatible
  - reg
  - gpio-controller
  - "#gpio-cells"

Since the schema permits incomplete node definitions, this example can pass
dt_binding_check validation silently despite omitting the mandatory
interrupt-controller and #interrupt-cells properties.

> +
> +                    ipmi@4 {
> +                        compatible = "nvidia,lstp-ipmi";
> +                        reg = <4>;
> +                    };
[ ... ]
> +            i2c@1 {
> +                compatible = "nvidia,lstp-i2c";
> +                reg = <1>;
> +                #address-cells = <1>;
> +                #size-cells = <0>;
> +            };
> +
> +            gpio@2 {
> +                compatible = "nvidia,lstp-gpio";
> +                reg = <2>;
> +                gpio-controller;
> +                #gpio-cells = <2>;
> +            };

[Severity: Low]
Does this example also omit the mandatory interrupt-related properties?

Similar to the previous example, this node is missing the interrupt-controller
and #interrupt-cells properties required for a hardware variant with interrupt
controller capabilities.

> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012-lstp-usb-adapter-v1-0-aambrozewicz@nvidia.com?part=4