Re: [PATCH v2 22/24] usb: dwc3: generic-plat: Add ZTE ZX279128S

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] usb: dwc3: generic: clock leak in resume error path
--

commit b05da126b481233779c64514b7441eac703bad0d
Author: Navid Ghahremani <ghahramani.navid@gmail.com>

usb: dwc3: generic-plat: Add ZTE ZX279128S

This commit uses the generic DWC3 platform integration to enable clocks
and release resets for the ZTE ZX279128S SoC.

> diff --git a/drivers/usb/dwc3/dwc3-generic-plat.c b/drivers/usb/dwc3/dwc3-generic-plat.c
> index ca69ac0eb07ce..aa838cf0676f2 100644
> --- a/drivers/usb/dwc3/dwc3-generic-plat.c
> +++ b/drivers/usb/dwc3/dwc3-generic-plat.c
> @@ -237,6 +237,7 @@ static const struct of_device_id dwc3_generic_of_match[] = {
>  	{ .compatible = "fsl,ls1028a-dwc3", &fsl_ls1028_dwc3},
>  	{ .compatible = "eswin,eic7700-dwc3", &eic7700_dwc3},
>  	{ .compatible = "starfive,jhb100-dwc3", },
> +	{ .compatible = "zte,zx279128s-dwc3", },

[Severity: Medium]
Does dwc3_generic_resume() leak the clock prepare/enable counts if
dwc3_pm_resume() returns an error during system resume?

drivers/usb/dwc3/dwc3-generic-plat.c:dwc3_generic_resume() {
	...
	ret = clk_bulk_prepare_enable(dwc3g->num_clocks, dwc3g->clks);
	if (ret)
		return ret;

	ret = dwc3_pm_resume(dwc);
	if (ret)
		return ret;
	...
}

Should clk_bulk_disable_unprepare() be called in the error path before
returning?

>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, dwc3_generic_of_match);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014072109.1759502-1-ghahramani.navid@gmail.com?part=22