From: sashiko-bot@kernel.org
To: "Orgad Shaneh" <orgads@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: octeon-hcd: fix the kernel-doc of struct octeon_hcd
Date: Thu, 15 Oct 2026 19:42:10 +0000 [thread overview]
Message-ID: <sashiko-outbox-173362@kernel.org> (raw)
In-Reply-To: <20261015194043.1597422-1-orgads@gmail.com>
> The struct octeon_hcd comment opens with /** but names its members
> without the @ prefix, so kernel-doc sees none of them and warns about
> every member. aebbc7d63407 added sof_timer without a line at all,
> which the robot reports as a new W=1 warning.
>
> Prefix the members with @, drop "pipe", which is no longer a member,
> and describe the three that were missing: periodic, nonperiodic and
> sof_timer. scripts/kernel-doc -Wall reports nothing for octeon_hcd
> afterwards.
>
> Fixes: aebbc7d63407 ("usb: octeon-hcd: sleep on an hrtimer for far-off periodic transfers")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202610151637.5srThc2q-lkp@intel.com/
> Assisted-by: LLM
> Signed-off-by: Orgad Shaneh <orgads@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261015194043.1597422-1-orgads@gmail.com?part=1
prev parent reply other threads:[~2026-10-15 19:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202610151637.5srThc2q-lkp@intel.com>
2026-10-15 19:40 ` [PATCH] usb: octeon-hcd: fix the kernel-doc of struct octeon_hcd Orgad Shaneh
2026-10-15 19:42 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-173362@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=orgads@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox