From: sashiko-bot@kernel.org
To: "Hanson Wang" <hanson.wang@ugreen.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH net v2] net: usb: aqc111: fix set_mac_address return value
Date: Fri, 16 Oct 2026 12:39:13 +0000 [thread overview]
Message-ID: <sashiko-outbox-174305@kernel.org> (raw)
In-Reply-To: <20261016122944.1889622-1-hanson.wang@ugreen.com>
> aqc111_set_mac_addr() returns the result of aqc111_write_cmd() on
> success. That function wraps usb_control_msg(), which returns the
> number of bytes transferred (6 for ETH_ALEN) rather than zero.
>
> Callers such as netif_set_mac_address() and bonding treat any
> non-zero return value as failure when setting the MAC address.
>
> Return 0 on success and propagate negative error codes on failure.
>
> Link: https://lore.kernel.org/netdev/20260703073936.462231-1-hanson.wang@ugreen.com
>
> Signed-off-by: Hanson Wang <hanson.wang@ugreen.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261016122944.1889622-1-hanson.wang@ugreen.com?part=1
next prev parent reply other threads:[~2026-10-16 12:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 7:39 [PATCH 1/1] net: usb: aqc111: fix set_mac_address return value for bonding Hanson Wang
2026-07-03 16:46 ` Andrew Lunn
2026-07-04 8:42 ` Hanson Wang
2026-07-04 14:32 ` Andrew Lunn
2026-07-20 23:38 ` Jakub Kicinski
2026-10-16 12:29 ` [PATCH net v2] net: usb: aqc111: fix set_mac_address return value Hanson Wang
2026-10-16 12:33 ` netdev-bot+sinfo
2026-10-16 12:39 ` sashiko-bot [this message]
2026-10-16 12:48 ` Hanson Wang
2026-10-16 12:53 ` netdev-bot+sinfo
2026-10-16 12:59 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-174305@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=hanson.wang@ugreen.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox