Re: [PATCH 1/2] PCI: pciehp: Defer device replacement handling until ->resume()

[sashiko-bot@kernel.org]

> On a Lenovo ThinkPad P16 Gen3 with a discrete Thunderbolt 5 host
> controller (Intel JHL9580 "Barlow Ridge") below Root Port 0000:80:1b.4,
> resume from suspend-to-idle intermittently hangs with a black screen:
> 
>   pcieport 0000:80:1b.4: Data Link Layer Link Active not set in 100 msec
>   pcieport 0000:80:1b.4: pciehp: Slot(25): Card not present
>   thunderbolt 0000:8a:00.0: RX ring 0 already stopped
>   ...
>   Oops: general protection fault, kernel NULL pointer dereference 0x32b
>   Workqueue: async async_run_entry_fn
>   RIP: 0010:tb_resume_noirq+0x3f/0x2e0 [thunderbolt]
>   Call Trace:
>    tb_domain_resume_noirq+0x42/0x60 [thunderbolt]
>    dpm_run_callback+0x4b/0x140
>    device_resume_noirq+0x16d/0x2c0
> [ ... ]
> followed by ->resume(), so resume from hibernation is fixed as well.
> 
> Fixes: 9d573d19547b ("PCI: pciehp: Detect device replacement during system sleep")
> Cc: stable@vger.kernel.org # v6.11+
> Signed-off-by: Cole Leavitt <cole@unwrap.rs>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018163910.132231-1-cole@unwrap.rs?part=1