From: sashiko-bot@kernel.org
To: "Yu Zhang" <yuz08559@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_hid: avoid copy_from_user() under get_report_spinlock
Date: Tue, 20 Oct 2026 08:20:41 +0000 [thread overview]
Message-ID: <sashiko-outbox-178522@kernel.org> (raw)
In-Reply-To: <20261020051446.92179-1-yuz08559@gmail.com>
> f_hidg_get_report() copies the userspace report into a freshly allocated
> 'entry' before taking get_report_spinlock. When the report id is already
> present in the list it then copies the same userspace buffer a second
> time into the existing entry, this time while holding get_report_spinlock
> (acquired with spin_lock_irqsave()):
>
> spin_lock_irqsave(&hidg->get_report_spinlock, flags);
> ptr = f_hidg_search_for_report(hidg, report_id);
> if (ptr) {
> if (copy_from_user(&ptr->report_data, buffer,
> sizeof(struct usb_hidg_report))) {
>
> copy_from_user() may fault and sleep, which is not allowed while holding
> a spinlock with interrupts disabled:
>
> [ ... ]
> also drops a redundant second read of the user buffer.
>
> Fixes: a139c98f760e ("USB: gadget: f_hid: Add GET_REPORT via userspace IOCTL")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yu Zhang <yuz08559@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261020051446.92179-1-yuz08559@gmail.com?part=1
prev parent reply other threads:[~2026-10-20 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 5:14 [PATCH] usb: gadget: f_hid: avoid copy_from_user() under get_report_spinlock Yu Zhang
2026-10-20 8:20 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-178522@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yuz08559@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox