From: sashiko-bot@kernel.org
To: "Nicolai Buchwitz" <nb@tipi-net.de>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH net v2 2/2] net: usb: cdc_mbim: don't enable BHs in tx_fixup under netpoll
Date: Wed, 21 Oct 2026 08:11:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-179944@kernel.org> (raw)
In-Reply-To: <20261021-cdc-ncm-netpoll-v2-2-8818965bbb69@tipi-net.de>
> cdc_mbim_tx_fixup() has the same spin_unlock_bh() as cdc_ncm_tx_fixup().
> Under netpoll it runs pending softirqs while the txq lock is held, and
> a transmit from one of them spins on that lock.
>
> Use spin_lock_irqsave() as in cdc_ncm.
>
> Fixes: 9bf211a30b3f ("net: cdc_mbim: adding MBIM driver")
> Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261021-cdc-ncm-netpoll-v2-0-8818965bbb69@tipi-net.de?part=2
next prev parent reply other threads:[~2026-10-21 8:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 7:56 [PATCH net v2 0/2] net: usb: cdc_ncm/cdc_mbim: fix netpoll lockup in tx_fixup Nicolai Buchwitz
2026-10-21 7:56 ` [PATCH net v2 1/2] net: usb: cdc_ncm: don't enable BHs in tx_fixup under netpoll Nicolai Buchwitz
2026-10-21 8:11 ` sashiko-bot
2026-10-22 12:58 ` Simon Horman
2026-10-21 7:56 ` [PATCH net v2 2/2] net: usb: cdc_mbim: " Nicolai Buchwitz
2026-10-21 8:11 ` sashiko-bot [this message]
2026-10-22 12:58 ` Simon Horman
2026-10-23 20:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-179944@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nb@tipi-net.de \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox