Re: [PATCH v2] usb-storage: option_ms: bound probe-time bulk transfers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] usb-storage: option_ms: undeclared helper usb_stor_bulk_transfer_buf_timeout()
--

commit 67810d8c99cea0179f022bfe478460be6b644ac8
Author: Lee Yongjun <jun85566@gmail.com>

usb-storage: option_ms: bound probe-time bulk transfers

This commit replaces the bulk transfer calls in option_rezero() and
option_inquiry() with usb_stor_bulk_transfer_buf_timeout() to bound probe-time
transfers to 5 seconds. As noted in the patch commentary, this change depends
on an unmerged series from Hongyu Xie that introduces the timeout helper.

> diff --git a/drivers/usb/storage/option_ms.c b/drivers/usb/storage/option_ms.c
> index 7c0b05a365543..d844fcaaf3fc6 100644
> --- a/drivers/usb/storage/option_ms.c
> +++ b/drivers/usb/storage/option_ms.c

[ ... ]

> @@ -44,9 +46,9 @@ static int option_rezero(struct us_data *us)
>  		return USB_STOR_TRANSPORT_ERROR;
>  
>  	memcpy(buffer, rezero_msg, sizeof(rezero_msg));
> -	result = usb_stor_bulk_transfer_buf(us,
> -			us->send_bulk_pipe,
> -			buffer, sizeof(rezero_msg), NULL);
> +	result = usb_stor_bulk_transfer_buf_timeout(us, us->send_bulk_pipe,
> +						    buffer, sizeof(rezero_msg), NULL,
> +						    OPTION_MS_PROBE_TIMEOUT);
>  	if (result != USB_STOR_XFER_GOOD) {
>  		result = USB_STOR_XFER_ERROR;
>  		goto out;
> @@ -56,14 +58,14 @@ static int option_rezero(struct us_data *us)
>  	 * Some of the devices need to be asked for a response, but we don't
>  	 * care what that response is.
>  	 */
> -	usb_stor_bulk_transfer_buf(us,
> -			us->recv_bulk_pipe,
> -			buffer, RESPONSE_LEN, NULL);
> +	usb_stor_bulk_transfer_buf_timeout(us, us->recv_bulk_pipe,
> +					   buffer, RESPONSE_LEN, NULL,
> +					   OPTION_MS_PROBE_TIMEOUT);
>  
>  	/* Read the CSW */
> -	usb_stor_bulk_transfer_buf(us,
> -			us->recv_bulk_pipe,
> -			buffer, 13, NULL);
> +	usb_stor_bulk_transfer_buf_timeout(us, us->recv_bulk_pipe,
> +					   buffer, 13, NULL,
> +					   OPTION_MS_PROBE_TIMEOUT);
>  
>  	result = USB_STOR_XFER_GOOD;
>  
> @@ -90,17 +92,17 @@ static int option_inquiry(struct us_data *us)
>  		return USB_STOR_TRANSPORT_ERROR;
>  
>  	memcpy(buffer, inquiry_msg, sizeof(inquiry_msg));
> -	result = usb_stor_bulk_transfer_buf(us,
> -			us->send_bulk_pipe,
> -			buffer, sizeof(inquiry_msg), NULL);
> +	result = usb_stor_bulk_transfer_buf_timeout(us, us->send_bulk_pipe,
> +						    buffer, sizeof(inquiry_msg), NULL,
> +						    OPTION_MS_PROBE_TIMEOUT);
>  	if (result != USB_STOR_XFER_GOOD) {
>  		result = USB_STOR_XFER_ERROR;
>  		goto out;
>  	}
>  
> -	result = usb_stor_bulk_transfer_buf(us,
> -			us->recv_bulk_pipe,
> -			buffer, 0x24, NULL);
> +	result = usb_stor_bulk_transfer_buf_timeout(us, us->recv_bulk_pipe,
> +						    buffer, 0x24, NULL,
> +						    OPTION_MS_PROBE_TIMEOUT);
>  	if (result != USB_STOR_XFER_GOOD) {
>  		result = USB_STOR_XFER_ERROR;
>  		goto out;
> @@ -112,9 +114,9 @@ static int option_inquiry(struct us_data *us)
>  		result = memcmp(buffer+8, "ZCOPTION", 8);
>  
>  	/* Read the CSW */
> -	usb_stor_bulk_transfer_buf(us,
> -			us->recv_bulk_pipe,
> -			buffer, 13, NULL);
> +	usb_stor_bulk_transfer_buf_timeout(us, us->recv_bulk_pipe,
> +					   buffer, 13, NULL,
> +					   OPTION_MS_PROBE_TIMEOUT);
>  
>  out:
>  	kfree(buffer);

[Severity: Low]
Does building drivers/usb/storage/option_ms.c with CONFIG_USB_STORAGE enabled
fail here with an implicit function declaration error?

In drivers/usb/storage/option_ms.c, option_rezero() and option_inquiry() call
usb_stor_bulk_transfer_buf_timeout(), but drivers/usb/storage/transport.h only
declares usb_stor_bulk_transfer_buf():

    extern int usb_stor_bulk_transfer_buf(struct us_data *us, unsigned int pipe,
                    void *buf, unsigned int length, unsigned int *act_len);

and usb_stor_bulk_transfer_buf_timeout() is not yet defined in
drivers/usb/storage/transport.c because the prerequisite patch series is not
present in the tree.

([1] https://lore.kernel.org/r/20261001123135.38831-1-xy521521@gmail.com/)

([1] Note: this patch mentions a dependency below "---" on Hongyu Xie's
pending series, which may explain why usb_stor_bulk_transfer_buf_timeout()
is missing in this tree.)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261021081616.89976-1-jun85566@gmail.com?part=1