Re: [PATCH] usbip: tools: add --sockfd option to usbip attach

[sashiko-bot@kernel.org]

> 'usbip attach' always opens its own TCP connection to --remote. A client
> that reaches the USB/IP server some other way, for example over a UNIX
> domain socket or a channel forwarded by a multiplexed SSH connection,
> therefore has to expose a listening TCP port on the local host just so
> usbip can connect back to it. Any local user can connect to that port
> while it is open.
> 
> Add a '--sockfd <fd>' option (short option '-s') that attaches the
> device over an inherited, already-connected stream socket instead.
> '--sockfd' and '--remote' are mutually exclusive. Because sudo closes
> file descriptors >= 3 by default but preserves stdin, the typical
> invocation passes the socket as stdin:
> 
>   sudo usbip attach --sockfd 0 --busid <busid>
> 
> [ ... ]
> 'usbip://unix:-/<busid>'.
> 
> Update doc/usbip.8 and the usage text accordingly.
> 
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261021214808.58609-1-rrangel@chromium.org?part=1