Re: [PATCH net v2] net: usb: cdc_ncm: add Apple Silicon MacBook Air (05ac:1903) device ID

[sashiko-bot@kernel.org]

> The Apple Silicon MacBook Air exposes a CDC-NCM interface (05ac:1903)
> when connected host-to-host over USB-C.
> 
> The device tested is an Apple MacBook Air (13-inch, M1, 2020), Model A2337
> (MacBookAir10,1) with an Apple M1 chip. Unlike
> commit a5148bc2fa27 ("net: usb: cdc_ncm: add Apple Mac USB-C direct networking quirk")
> which hypothesized all Apple Silicon Macs share PID 0x1905 ("Mac"), this
> M1 MacBook Air exposes PID 0x1903 with iProduct string "MacBook Air".
> 
> Like other Apple CDC-NCM peripherals (0x1902 and 0x1905), Apple's
> firmware omits the CDC status interrupt endpoint. This causes the
> standard cdc_ncm probe to fail with a missing endpoint error:
> 
>   cdc_ncm 1-7:1.0: bind() failure
>   cdc_ncm: probe of 1-7:1.0 failed with error -22
> [ ... ]
>         bInterfaceClass        10 CDC Data
>         bNumEndpoints           2
> 
> Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>
> Signed-off-by: Divyanshu Jha <divyanshuj2006@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261024122051.14427-1-divyanshuj2006@gmail.com?part=1